Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: add support for json output for notation verify (#527)" #551

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

priteshbandi
Copy link
Contributor

This reverts commit 33c2281.

We are reverting #527 because we need to write spec first for json output.

@codecov-commenter
Copy link

Codecov Report

Merging #551 (19ed2bd) into main (c47a452) will increase coverage by 0.14%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #551      +/-   ##
==========================================
+ Coverage   36.20%   36.34%   +0.14%     
==========================================
  Files          30       30              
  Lines        1616     1607       -9     
==========================================
- Hits          585      584       -1     
+ Misses       1010     1002       -8     
  Partials       21       21              
Impacted Files Coverage Δ
cmd/notation/verify.go 24.13% <0.00%> (+0.93%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

byronchien
byronchien previously approved these changes Feb 15, 2023
gokarnm
gokarnm previously approved these changes Feb 15, 2023
Copy link
Contributor

@gokarnm gokarnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT previously approved these changes Feb 15, 2023
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JeyJeyGao
JeyJeyGao previously approved these changes Feb 15, 2023
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@patrickzheng200 patrickzheng200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@patrickzheng200 patrickzheng200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit 54b42cb into notaryproject:main Feb 15, 2023
duffney pushed a commit to duffney/notation that referenced this pull request Mar 30, 2023
…ryproject#527)" (notaryproject#551)

This reverts commit 33c2281.

We are reverting notaryproject#527 because we need to write spec first for json output.

Signed-off-by: Pritesh Bandi <[email protected]>
Signed-off-by: Josh Duffney <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants