feat(doc): simplify signing experience #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priteshbandi
requested review from
yizha1,
shizhMSFT,
iamsamirzon and
patrickzheng200
iamsamirzon
previously approved these changes
Feb 17, 2023
JeyJeyGao
reviewed
Feb 17, 2023
priteshbandi
changed the title
shizhMSFT
changed the title
shizhMSFT
changed the title
shizhMSFT
reviewed
Mar 1, 2023
yizha1
reviewed
Mar 1, 2023
There was a problem hiding this comment.
I vote for @shizhMSFT 's comment.
Thanks @priteshbandi to introduce a new option for users to sign using on-demand key
priteshbandi
requested review from
gokarnm,
justincormack,
NiazFK,
rgnote and
SteveLasker
as code owners
Signed-off-by: Pritesh Bandi <[email protected]>
priteshbandi
pushed a commit
that referenced
this pull request
Mar 7, 2023
This PR introduces a new option for users to sign using an on-demand key. Users are able to sign without needing to add a key first. This PR intends to address the following issue: #537 based on spec changes in #553 ``` c889f3b9d811:notation kodysk$ ./bin/notation sign --plugin com.example.plugin --id example:test-id $IMAGE Warning: Always sign the artifact using digest(@sha256:...) rather than a tag(:v1) because tags are mutable and a tag reference can point to a different artifact than the one signed. Successfully signed localhost:5000/net-monitor@sha256:07c30edca95116e23f6a150ba3f7ed296eca71021dba9d9569eb07820f8c0e7d ``` Signed-off-by: Kody Kimberl <[email protected]>
duffney
pushed a commit
to duffney/notation
that referenced
this pull request
Mar 30, 2023
Related issue notaryproject#537 Signed-off-by: Pritesh Bandi <[email protected]> Signed-off-by: Josh Duffney <[email protected]>
duffney
pushed a commit
to duffney/notation
that referenced
this pull request
Mar 30, 2023
This PR introduces a new option for users to sign using an on-demand key. Users are able to sign without needing to add a key first. This PR intends to address the following issue: notaryproject#537 based on spec changes in notaryproject#553 ``` c889f3b9d811:notation kodysk$ ./bin/notation sign --plugin com.example.plugin --id example:test-id $IMAGE Warning: Always sign the artifact using digest(@sha256:...) rather than a tag(:v1) because tags are mutable and a tag reference can point to a different artifact than the one signed. Successfully signed localhost:5000/net-monitor@sha256:07c30edca95116e23f6a150ba3f7ed296eca71021dba9d9569eb07820f8c0e7d ``` Signed-off-by: Kody Kimberl <[email protected]> Signed-off-by: Josh Duffney <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #537
Signed-off-by: Pritesh Bandi [email protected]