Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add label and notes for experimental features #577

Merged
merged 2 commits into from
Mar 3, 2023

Conversation

yizha1
Copy link
Contributor

@yizha1 yizha1 commented Mar 3, 2023

This PR partly resolves issue #576

  • Lable flag --signature-manifest as experimental feature
  • Add notes for using artifact manifest

Signed-off-by: Yi Zha [email protected]

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2023

Codecov Report

Merging #577 (a64de0e) into main (b20f811) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #577   +/-   ##
=======================================
  Coverage   34.36%   34.36%           
=======================================
  Files          32       32           
  Lines        1848     1848           
=======================================
  Hits          635      635           
  Misses       1192     1192           
  Partials       21       21           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@patrickzheng200 patrickzheng200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 55f0764 into notaryproject:main Mar 3, 2023
@yizha1 yizha1 deleted the sign_spec branch March 4, 2023 01:09
duffney pushed a commit to duffney/notation that referenced this pull request Mar 30, 2023
This PR partly resolves issue notaryproject#576
- Lable flag `--signature-manifest` as experimental feature
- Add notes for using artifact manifest

Signed-off-by: Yi Zha <[email protected]>
Signed-off-by: Josh Duffney <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants