Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add an example to CLI help info for notation sign #585

Merged
merged 1 commit into from
Apr 21, 2023
Merged

doc: add an example to CLI help info for notation sign #585

merged 1 commit into from
Apr 21, 2023

Conversation

FeynmanZhou
Copy link
Member

Fix #584

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2023 •
edited
Loading

Codecov Report

Merging #585 (a9a0c43) into main (17d3525) will increase coverage by 0.09%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #585      +/-   ##
==========================================
+ Coverage   33.06%   33.16%   +0.09%     
==========================================
  Files          32       32              
  Lines        2011     2014       +3     
==========================================
+ Hits          665      668       +3     
  Misses       1324     1324              
  Partials       22       22
Impacted Files Coverage Δ
cmd/notation/sign.go 41.79% <100.00%> (+1.33%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

kody-kimberl
kody-kimberl reviewed Mar 7, 2023
View reviewed changes
cmd/notation/sign.go Outdated Show resolved Hide resolved
kody-kimberl
kody-kimberl previously approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@kody-kimberl kody-kimberl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

patrickzheng200
patrickzheng200 previously approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@patrickzheng200 patrickzheng200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi previously approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

patrickzheng200
patrickzheng200 approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@patrickzheng200 patrickzheng200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit 225ff17 into notaryproject:main Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kody-kimberl kody-kimberl kody-kimberl left review comments

@priteshbandi priteshbandi priteshbandi approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@patrickzheng200 patrickzheng200 patrickzheng200 approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@JeyJeyGao JeyJeyGao Awaiting requested review from JeyJeyGao JeyJeyGao is a code owner

@justincormack justincormack Awaiting requested review from justincormack

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an example to CLI help info for notation signing
6 participants
@FeynmanZhou @codecov-commenter @priteshbandi @shizhMSFT @kody-kimberl @patrickzheng200