fix: added warning for dangling referrers index deletion #619
Conversation
Signed-off-by: Patrick Zheng <[email protected]>
patrickzheng200
requested review from
gokarnm,
JeyJeyGao,
justincormack,
NiazFK,
priteshbandi,
rgnote,
shizhMSFT and
SteveLasker
as code owners
Signed-off-by: Patrick Zheng <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #619 +/- ##
==========================================
- Coverage 34.43% 34.28% -0.15%
==========================================
Files 32 32
Lines 1844 1852 +8
==========================================
Hits 635 635
- Misses 1188 1196 +8
Partials 21 21
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Should the exit code be zero? /cc @toddysm |
|
@sajayantony I believe so and avoid braking any scripts. Also, is this the only message we will show: I believe there should still be a confirmation that the operation succeeded and the signature got attached to the artifact. We should show the standard message we show when signature is attached + the warning. |
| @@ -22,6 +23,8 @@ const ( | |||
| signatureManifestImage = "image" | |||
| ) | |||
|
|
|||
| const referrersTagSchemaDeleteError = "failed to delete dangling referrers index" | |||
There was a problem hiding this comment.
@shizhMSFT @Wwwsylvia Since this error is generated based on oras-go-specific procedure, should oras-go export this error so caller can implement upon?
There was a problem hiding this comment.
It's beyond this PR's scope, I created an issue for tracking, let's move discussion there.
There was a problem hiding this comment.
Yeah we need to think about how to improve oras-go for such use case.
There was a problem hiding this comment.
Once oras-go is updated and have a new release, we can update here. But for now, let's do a string match.
Yes, the exit code should be 0. Once the warning is printed out, |
This warning message is an addition to the standard result. Can refer this in the code. |
Signed-off-by: Patrick Zheng <[email protected]>
|
Closing this PR due to suggestion here: #615 (comment). |
|
Reopened based on discussion. |
Signed-off-by: Patrick Zheng <[email protected]>
This PR tries to resolve #615.