Apply suggestions from code review

Making it even better by condensing it to a single monitor string set for error checking Co-authored-by: Jeremy Friesen <[email protected]>
notch8 · Mar 29, 2024 · 91344be · 91344be
1 parent d0b1009
commit 91344be
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/app/models/fcrepo_endpoint.rb b/app/models/fcrepo_endpoint.rb
@@ -17,7 +17,7 @@ def ping
     ).response.success?
       "Fedora is OK"
     else
-      "Fedora is Down"
+      "Error checking Fedora status: Fedora is Down"
     end
   rescue StandardError => e
     "Error checking Fedora status: #{e.message}"

diff --git a/spec/models/fcrepo_endpoint_spec.rb b/spec/models/fcrepo_endpoint_spec.rb
@@ -28,7 +28,7 @@
 
       it 'returns "Fedora is Down"' do
         allow(ActiveFedora::Fedora.instance.connection).to receive(:head).with(url_prefix).and_return(failure_response)
-        expect(subject.ping).to eq("Fedora is Down")
+        expect(subject.ping).to eq("Error checking Fedora status: Fedora is Down")
       end
     end