This repository has been archived by the owner on Oct 24, 2024. It is now read-only.
i319 - make ocr searching work #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will add an over to IiifPrint::LineageService to look for slugs over ids. Also, we found that in some cases using `--psm 1` had problems where it flips the image incorrectly when the image is already in the right orientation. Considerations will be needed for images that are actually in the wrong orientation though.
laritakr
reviewed
Apr 5, 2023
| # frozen_string_literal: true | ||
|
|
||
| # OVERRIDE: IIIF Print v1.0.0 to work with slugs | ||
| IiifPrint::LineageService.module_eval do |
There was a problem hiding this comment.
Since this is a slug-related override, I was wondering if there is a reason it wasn't added to slug_override.rb (I haven't looked into it.. not everything works there, but most overrides do).
There was a problem hiding this comment.
Hmm…I like that we have a decorator, but I also want a reference to this use in SlugBug.
Also I'm wondering if work.to_param is the better method?
There was a problem hiding this comment.
slug_override.rb IS the full set of decorators for everything slug-related here. So if we do an override, I'd prefer it go in there. But the configuration option is good.
jeremyf
added a commit
to notch8/iiif_print
that referenced
this pull request
Apr 5, 2023
Prior to this commit, we assumed that a work's `id` was the mechanism for always identifying a work in regards to it's ancestry/lineage. However, for implmentations that incorproate slug behavior, that reality is not always the case. With this commit, we expose a configurable mechanism for altering the ancestry functionality. Related to: - notch8/adventist-dl#354 - https://github.com/scientist-softserv/adventist-dl/issues/319
|
I went ahead and minted a configurable option for IIIF Print: notch8/iiif_print#209 That should remove the need for a decorator and we can instead move the logic into an initializer and document accordingly. |
jeremyf
added a commit
to notch8/iiif_print
that referenced
this pull request
Apr 5, 2023
Prior to this commit, we assumed that a work's `id` was the mechanism for always identifying a work in regards to it's ancestry/lineage. However, for implmentations that incorproate slug behavior, that reality is not always the case. With this commit, we expose a configurable mechanism for altering the ancestry functionality. Related to: - notch8/adventist-dl#354 - https://github.com/scientist-softserv/adventist-dl/issues/319
This commit will favor the use of SlugBug over the override since the logic has been set up with the new configuration in IIIF Print. ref: notch8/iiif_print@ba4e955 Also, updated to the latest IIIF Print to see improvements with the `identify` call. ref: https://github.com/scientist-softserv/iiif_print/blob/62686fc62180d7d89654bf1fa726efc30cf6d351/lib/iiif_print/image_tool.rb#L77
kirkkwang
changed the title
ShanaLMoore
approved these changes
Apr 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: notch8/adventist_knapsack#428
This commit will add an over to IiifPrint::LineageService to look for slugs over ids. Also, we found that in some cases using
--psm 1had problems where it flips the image incorrectly when the image is already in the right orientation. Considerations will be needed for images that are actually in the wrong orientation though.