This repository has been archived by the owner on Oct 24, 2024. It is now read-only.
Fixing arity mismatch for ImportUrlJob#send_error #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In v2.9.6 of Hyrax we saw the following error: > File Import Error > Error: wrong number of arguments (given 2, expected 1) It masks other errors, because the message sending for errors is itself raising an error. With this change, we ignore all extra parameters and pass the first parameter. Related to: - samvera/hyrax#2821 Resolved in: - samvera/hyrax#4243 - samvera/hyrax@bfd316e
laritakr
approved these changes
Apr 10, 2023
Prior to this commit, we were taking an exception and passing just the message to the user. We abandoned the useful backtrace and context. With this commit, we add error logging of the back trace. An outstanding question is "What would be the consequence of re-raising the exception?" Would this help us gain better insight into what's going on? It seems like we probably should do that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing arity mismatch for ImportUrlJob#send_error
7b21584
In v2.9.6 of Hyrax we saw the following error:
It masks other errors, because the message sending for errors is itself
raising an error.
With this change, we ignore all extra parameters and pass the first
parameter.
Related to:
Resolved in:
Adding logging for muted exception
811b738
Prior to this commit, we were taking an exception and passing just the
message to the user. We abandoned the useful backtrace and context.
With this commit, we add error logging of the back trace.
An outstanding question is "What would be the consequence of re-raising
the exception?" Would this help us gain better insight into what's
going on? It seems like we probably should do that.