-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catalog search and work pages displaying "date issued" metadata field tag #169
Comments
PR ready for review - #809 |
# Story Updates metadata tag label for `date_issued` to display 'Date' on show and index pages. Refs - #169 # Expected Behavior Before Changes Date issued metadata tag displays 'Date issued' # Expected Behavior After Changes Date issued metadata tag displays 'Date' # Screenshots / Video <details> ## Before ![image](https://github.com/user-attachments/assets/0a6be042-c71f-4b7e-8669-5d8bc3f9299f) ## After ![image](https://github.com/user-attachments/assets/49d6517e-5f6e-4738-9354-c55d25e4dbfd) </details> # Notes
QA RESULTS: ✅ PASStested on STAGING COLLECTION ⚠ NEEDS REVIEW
This collection duplicate Date fields now. Which date fields is correct? WORKS ✅
|
I originally marked this as NEEDS REWORK because I thought we introduced a bug for the collection. However, production behaves the same way. ref: Collection Because of this, we've technically have reached feature parity and completed the original ask. A separate ticket should be made to address the duplicate Date fields on the collection form, if the client deems it to be an issue. Furthermore, removing one of the date properties from the collection may be risky because prod data could be using either or both. We'd be at risk of losing data if both no longer exists when converting them to valkyrie. |
I've known about the duplicate date labels from day one. It's a leftover bug that my predecessor introduced when he was customizing our tenant. I agree that feature parity is met. No problems remain. |
Summary
Prior to Knapsack, our catalog search and work pages were configured to show the date issued field with the label "Date," not "Date issued." Post Knapsack, the work page and the catalog search metadata preview is displaying "Date issued," which is terminology that doesn't make sense for some of our works. It is also inconsistent because the back-end of the UI still calls the field in question "Date," so we need that consistency between field labels to return.
Acceptance Criteria
Screenshots or Video
Screenshots of ADL and SDAPI production site catalogs prior to Knapsack. Dates are 3/2023, 7/2023 (ADL), and 1/2024 (SDAPI):
Screenshots of ADL and SDAPI production site catalogs post Knapsack, taken today:
Back-end of a work on ADL, which still shows "Date" as the label for the field that is reverting to "Date issued" on the work page and in the catalog search.
The front end of that same work, which shows "Date issued" for the field that is called "Date" on the back-end:
Testing Instructions
Expected Behavior Before Changes
Date issued metadata tag displays 'Date issued'
Expected Behavior After Changes
Date issued metadata tag displays 'Date'
Screenshots / Video
Before
After
Notes
The text was updated successfully, but these errors were encountered: