Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog search and work pages displaying "date issued" metadata field tag #169

Open
1 task done
Tracked by #134
KatharineV opened this issue Apr 23, 2024 · 4 comments
Open
1 task done
Tracked by #134
Assignees
Labels
bug something isn't working good first issue Knapsack Upgrade M3 Milestone 3

Comments

@KatharineV
Copy link
Collaborator

KatharineV commented Apr 23, 2024

Summary

Prior to Knapsack, our catalog search and work pages were configured to show the date issued field with the label "Date," not "Date issued." Post Knapsack, the work page and the catalog search metadata preview is displaying "Date issued," which is terminology that doesn't make sense for some of our works. It is also inconsistent because the back-end of the UI still calls the field in question "Date," so we need that consistency between field labels to return.

Acceptance Criteria

  • date issued label should display as Date

Screenshots or Video

Screenshots of ADL and SDAPI production site catalogs prior to Knapsack. Dates are 3/2023, 7/2023 (ADL), and 1/2024 (SDAPI):

Image

Image

Image

Screenshots of ADL and SDAPI production site catalogs post Knapsack, taken today:

Image

Image

Back-end of a work on ADL, which still shows "Date" as the label for the field that is reverting to "Date issued" on the work page and in the catalog search.

Image

The front end of that same work, which shows "Date issued" for the field that is called "Date" on the back-end:

Image

Testing Instructions

Expected Behavior Before Changes

Date issued metadata tag displays 'Date issued'

Expected Behavior After Changes

Date issued metadata tag displays 'Date'

Screenshots / Video

Before

image

After

image

Notes

@KatharineV KatharineV added bug something isn't working Knapsack Upgrade labels Apr 23, 2024
@kirkkwang kirkkwang transferred this issue from notch8/adventist-dl May 10, 2024
@jillpe jillpe moved this to Ready for Development in Adventist Knapsack May 10, 2024
@jillpe jillpe removed the status in Adventist Knapsack May 10, 2024
@jillpe jillpe moved this to Ready for Development in Adventist Knapsack May 15, 2024
@ShanaLMoore ShanaLMoore added the M3 Milestone 3 label Sep 3, 2024
@K8Sewell K8Sewell self-assigned this Sep 12, 2024
@K8Sewell K8Sewell moved this to In Development in adventist-dl Sep 12, 2024
@K8Sewell K8Sewell moved this to In Development in Adventist Knapsack Sep 12, 2024
@K8Sewell
Copy link
Contributor

PR ready for review - #809

@K8Sewell K8Sewell moved this from In Development to Code Review in Adventist Knapsack Sep 13, 2024
@K8Sewell K8Sewell moved this from In Development to Code Review in adventist-dl Sep 13, 2024
@jillpe jillpe moved this from Code Review to Deploy to Staging in Adventist Knapsack Sep 16, 2024
@jillpe jillpe moved this from Code Review to Deploy to Staging in adventist-dl Sep 16, 2024
ShanaLMoore pushed a commit that referenced this issue Sep 17, 2024
# Story
Updates metadata tag label for `date_issued` to display 'Date' on show
and index pages.


Refs

- #169 

# Expected Behavior Before Changes

Date issued metadata tag displays 'Date issued'

# Expected Behavior After Changes

Date issued metadata tag displays 'Date'

# Screenshots / Video

<details>

## Before


![image](https://github.com/user-attachments/assets/0a6be042-c71f-4b7e-8669-5d8bc3f9299f)

## After


![image](https://github.com/user-attachments/assets/49d6517e-5f6e-4738-9354-c55d25e4dbfd)

</details>

# Notes
@ShanaLMoore
Copy link

ShanaLMoore commented Sep 19, 2024

QA RESULTS: ✅ PASS

tested on STAGING

COLLECTION ⚠ NEEDS REVIEW

  • date issued label should display as Date. Yes but...

This collection duplicate Date fields now. Which date fields is correct?

Image

Image

WORKS ✅

  • date issued label should display as Date

Image

Image

Image

@ShanaLMoore ShanaLMoore added the needs rework issue needs additional work label Sep 19, 2024
@ShanaLMoore ShanaLMoore moved this from Deploy to Staging to Ready for Development in adventist-dl Sep 19, 2024
@ShanaLMoore ShanaLMoore moved this from Deploy to Staging to Ready for Development in Adventist Knapsack Sep 19, 2024
@ShanaLMoore
Copy link

ShanaLMoore commented Sep 19, 2024

I originally marked this as NEEDS REWORK because I thought we introduced a bug for the collection. However, production behaves the same way.

ref: Collection

image

Because of this, we've technically have reached feature parity and completed the original ask. A separate ticket should be made to address the duplicate Date fields on the collection form, if the client deems it to be an issue.

Furthermore, removing one of the date properties from the collection may be risky because prod data could be using either or both. We'd be at risk of losing data if both no longer exists when converting them to valkyrie.

@ShanaLMoore ShanaLMoore removed the needs rework issue needs additional work label Sep 19, 2024
@ShanaLMoore ShanaLMoore moved this from Ready for Development to Client QA in Adventist Knapsack Sep 19, 2024
@KatharineV
Copy link
Collaborator Author

I've known about the duplicate date labels from day one. It's a leftover bug that my predecessor introduced when he was customizing our tenant. I agree that feature parity is met. No problems remain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working good first issue Knapsack Upgrade M3 Milestone 3
Projects
Status: Deploy to Production
Development

No branches or pull requests

5 participants