Work page "Add to Collection" button does not work

[KatharineV]

While logged into demo.adventist-knapsack as an admin, I can see the "Add to collection" action button on a work's page. However, the button does not work. I cannot add to any collections.

I tried to add this work to two collections. One was already existing and I didn't create it. I created a second one just for the test, to confirm that it wasn't a permissions issue. I could not generate either collection name from the "Add to Collection" action button dropdown, so I couldn't add it to either collection.

Screenshots illustrating issue

Testing Instructions

Be sure you have one or more collections available to work with. Add works to a collection through each of the options:

• select one or more works from the dashboard list of works, and use the "Add to collection" button
• open a work's show page, and use the "Add to collection" button
• open a collection in the dashboard, and select "Add existing works to this collection"
• go to second page on dashboard works list. select one or more works and use the "Add to collection" button

[jillpe]

SoftServ QA

• ❌ select one or more works from the dashboard list of works, and use the "Add to collection" button
  • Clicking 'Save' results in an error

- open a work's show page, and use the "Add to collection" button - Clicking 'Save' results in an error

• open a collection in the dashboard, and select "Add existing works to this collection"
• Clicking 'Save' results in an error

[laritakr]

relates to samvera/hyku#2024

[ShanaLMoore]

QA RESULTS: PASS ✅

• select one or more works from the dashboard list of works, and use the "Add to collection" button
  DEMO: https://share.zight.com/5zuvNNlB

• open a work's show page, and use the "Add to collection" button
  DEMO: https://share.zight.com/qGuBJJeq

• open a collection in the dashboard, and select "Add existing works to this collection"
  DEMO: https://share.zight.com/2Nu9llnD

• go to second page on dashboard works list. select one or more works and use the "Add to collection" button
  DEMO: https://share.zight.com/4guWlPQA

[KatharineV]

ADL QA Results - Partial pass. Failure to search collections on single word, which is functionality that exists in our current production instance.

1. select one or more works from the dashboard list of works, and use the "Add to collection" button
   Does NOT work if we search a single word of the collection name.
   Did work when I searched two words of a collection name. Unfortunately, we must have functionality with one word searches. The drop down says the search will work with only 2 characters. That has never worked, but Hyku has worked to search collections with a single word prior to Knapsack, and we need Knapsack to have the same functionality.

Failure to search on one word:

Found the collection with two words:

ADL production dropdown finds collections with single word search:

3. open a work's show page, and use the "Add to collection" button
   Does NOT work if we search a single word of the collection name.
   Did work when I searched two words of a collection name. Unfortunately, we must have functionality with one word searches.

4. open a collection in the dashboard, and select "Add existing works to this collection"
   WORKED as expected

5. go to second page on dashboard works list. select one or more works and use the "Add to collection" button
   WORKED as expected

[ShanaLMoore]

A better solution is in place in Hyku main, which adventist will receive once we complete their upgrade. This may be a temporary inconvenience, but Rob said we've fixed this before in other projects so it's worth looking through repos.

[ShanaLMoore]

related to: https://github.com/scientist-softserv/adventist-dl/issues/623

[KatharineV]

Team, when I tested in February, I could add existing works to existing collections. Today I cannot (on ADL production--will add a comment if other environments behave differently). I get an error message if I try to add using the "Add to collection" button on a work page, if I go to a collection and choose "add existing works," and if I page through the dashboard and try to add works to collections. Nothing is effective to add works to collections right now. :(

[laritakr]

If you click on the collection inside the dashboard, I believe you should be able to add works using the options on that view. I would be interested to know if this will work.

[orangewolf]

this is working in staging as of today

[KatharineV]

Staging test

First note: We still have to enter two complete words in order to search for collections. On Production, we can search anywhere with only one word. We must have feature parity with the single word search, because we have single word collections on prod that we can't search for or add to if this upgrade removes the ability to search and find with only one word. Screenshot shows how I had to enter two words to find a collection.

Add existing works to this collection (works selected from page 1 of dashboard) - WORKS
Add existing works to this collection (works selected from page 6 of dashboard) - BUG
Add existing works to this collection (works selected after a keyword search of the dashboard) - BUG

• From the Alumni Parade collection on dashboard, I selected to add existing works. When I made my selections on page 1 of the dashboard, the works were successfully added to the collection. When I clicked into page 6 and followed the same steps, the add to collection feature showed all the right metadata but after submitting changes, it opened the collection and the newly added works were not present. Same thing happened when I keyword searched the dashboard, tried to add a work, everything looked right, I submitted, and the collection opened without the newly added work present.
  After "add existing works," I Keyword searched for "florida" and selected a work
  
  And it all looked right, but if you check you won't find the work in the collection.
  

Dashboard list of work add to collection - BUG

• I selected several works from the dashboard, tried to add to a collection, and got two results. The first time, the collection loaded as soon as I clicked "add to collection," but the works weren't present. I tried again, and I got an error message the second time. The works still aren't showing in the collection.
• 
  
  

Add to Collection from Work Page - BUG

• From a work page, the "add to collection" button will search and find a collection and will accept the click to submit the work, but the work doesn't show on the collection page and the collection isn't listed in the relationships for the work.
  Work I tested: https://adl.s2.adventistdigitallibrary.org/concern/journal_articles/aur_miller_01_004_013_d_hendrich_sermon_1825
  Collection I added it to using "add to collection" button (note it doesn't show in this collection): https://adl.s2.adventistdigitallibrary.org/dashboard/collections/ebbab001-fd0c-40f2-ab26-eebab8808392?locale=en