Issue with adding collections as subcollections

[ndroark]

Summary

I am trying to add collections to existing collections (while logged in as a superadmin), but after I select the subcollection from the dropdown list, I get this error message. Occuring in franklin.hykucommons.org.

Acceptance Criteria

• Any user with collection manager level permissions can add collections to existing collections through the dashboard
• This code has been contributed to the double combo or main branch (the longest running branch). Note that this rake task doesn't work as is on hyku since hyrax is v5+.

NOTE

This ticket was unrelated to permissions. If collection manager permissions continue, this should be a new ticket.

Testing

Verify that the 3 affected collections in Franklin tenant now show the full list of valid collections to be added as subcollections. The 3 affected collections were College Presidents, Franklin College in the News, and Lasting Legacies.

To test in staging, you would have to find an old collection (prior to 2024), create a new collection, and verify that subcollections can be added to each other.

[bkiahstroud]

@ndroark can you confirm whether or not this is still an issue?

Based on the screenshot, the intended parent collection is Lasting Legacies: Franklin College 'Spirit of Community' Collection, and the intended subcollection is Judi Warren '80.

Looking at the parent collection now, Judi Warren '80 is a subcollection:

Screenshot 1

Though I can tell from the URL that the Collection ID is different, maybe it was recreated?

I created two test collections in the franklin tenant and was able to add one as a subcollection to the other:

Screenshot 2

[ndroark]

The issue seems to still be present with at least certain collections in the tenant. For instance, this collection (https://franklin.hykucommons.org/dashboard/collections/39e102cc-551c-4d41-8f26-2d87190ac39f?locale=en) only lists two other collections as available to add to it, and doesn't show up in the list for other collections to be added to.

[ndroark]

This function should be not be limited to superadmins, any user with collection manager level permissions should be able to do this. The specific subcollections in the comments above in the Franklin tenant are the main area where problems have been observed.

[jillpe]

This might be associated with the pagination bug in adventist

[ShanaLMoore]

possible this may be fixed when upgrading. edit: it's also possible that fix wasn't applied to all controllers though

related tickets (should've been contributed back).

Is there an issue with permissions?

samvera/hyku#2024

notch8/adventist_knapsack#249

[jeremyf]

Things to look at:

https://github.com/samvera/hyrax/blob/e9141b81865a37fbc80ab88b44825a51534e6c48/app/controllers/hyrax/my/works_controller.rb#L32-L36

And we need to consider applying the cloning the of the object to the three other locations.

❯ rg "Hyrax::CollectionsService.new"
app/controllers/concerns/hyrax/works_controller_behavior.rb
173:      Hyrax::CollectionsService.new(self)

app/controllers/hyrax/my/works_controller.rb
35:        Hyrax::CollectionsService.new(cloned)

app/controllers/hyrax/dashboard/collections_controller.rb
387:        Hyrax::CollectionsService.new(self).search_results(:edit)

app/controllers/hyrax/homepage_controller.rb
25:    Hyrax::CollectionsService.new(self).search_results do |builder|

[laritakr]

There seem to be 3 collections in the franklin repo that are affected:

• https://franklin.hykucommons.org/dashboard/collections/39e102cc-551c-4d41-8f26-2d87190ac39f?locale=en
• https://franklin.hykucommons.org/dashboard/collections/0c3005c0-f126-4b7a-ac77-20a2b725f75b?locale=en
• https://franklin.hykucommons.org/dashboard/collections/3ced02ba-d2dd-49fe-af48-42207f013ce4?locale=en

These 3 can be added to each other, but are not options for any other collections. All other collections seem to work correctly. So far I have found no reason for this behavior and have been unable to duplicate the behavior locally. Editing and saving the Legacy collection did not fix anything.

These 3 collections seem to have been the first 3 collections created in the franklin tenant. Is it possible something changed in the code prior to the 4th collection being created in March of 2023?

[laritakr]

✅ Passes QA

• New collection: https://demo.commons-archive.org/collections/bd47476a-ab14-4688-a82d-b29574ea4a8b?locale=en
• Ran code from rake task to update collections on all tenants in dev environment (rake task threw faraday errors but code with a few revisions to handle invalid tenants worked from within the rails console.) Now that the collections have been migrated, the rake task is only for documentation purposes.
• Older collections now show in the list of available subcollections

Before data update

After data update