🐛 Update webapp for public #solr_document #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will update the hyrax-webapp submodule where we move the `#solr_document` method from private to public. The method being private was causing a crash in the Universal Viewer. As per Hyrax, the method should have been public in the first place. Ref: - samvera/hyku@dbe996e - https://github.com/samvera/hyrax/blob/b334e186e77691d7da8ed59ff27f091be1c2a700/app/presenters/hyrax/file_set_presenter.rb#L10 - https://github.com/scientist-softserv/adventist-dl/issues/624
kirkkwang
force-pushed
the
i624-solr-document-was-private
branch
2 times, most recently
from
c007d04 to
3c9d54d
Compare
The `fix_spec_reports` branch doesn't seem to exist anymore, going to use `v0.0.15` instead.
kirkkwang
force-pushed
the
i624-solr-document-was-private
branch
from
3c9d54d to
e34f93b
Compare
ShanaLMoore
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
This commit will update the hyrax-webapp submodule where we move the
#solr_documentmethod from private to public. The method being private was causing a crash in the Universal Viewer. As per Hyrax, the method should have been public in the first place.Ref:
Screenshots / Video
Before (on staging)
After