Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace SETTINGS_ env vars #2

Merged
merged 4 commits into from
Sep 22, 2023
Merged

Replace SETTINGS_ env vars #2

merged 4 commits into from
Sep 22, 2023

Conversation

laritakr
Copy link
Contributor

@laritakr laritakr commented Sep 22, 2023

Story

Refs #538

  • Compared to hyku readme, as well as other repos based on a more current Hyku to rename and/or remove settings vars.
  • Also alphabetized Hyku vars to simplify side-by-side comparisons.

Expected Behavior Before Changes

Files in /ops directory contained SETTINGS_ vars

Expected Behavior After Changes

All references to SETTINGS_ vars in are replaced or removed.

Screenshots / Video

Notes

THERE APPEARS TO BE NO HYKU EQUIVALENTS FOR

  • SETTINGS__DEVISE__INVITATION_FROM_EMAIL
  • SETTINGS__ZOOKEEPER__CONNECTION_STR

LaRita Robinson added 2 commits September 21, 2023 19:59
Compared to hyku readme, as well as other repos based on a more
current Hyku to rename and/or remove settings vars.

Also alphabetized Hyku vars to simplify side-by-side comparisons.
value: "true"
- name: SETTINGS__MULTITENANCY__DEFAULT_HOST
value: "%{tenant}.s2.adventistdigitallibrary.org"
- name: SETTINGS__MULTITENANCY__ENABLED
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious if there's there's an equivalent HYKU setting for this? Or does it just go away now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they go away

value: hyku-adventist-dev
- name: SETTINGS__ZOOKEEPER__CONNECTION_STR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here

@kirkkwang
Copy link
Contributor

Looks good, i left just some questions

@orangewolf orangewolf merged commit d4b693a into main Sep 22, 2023
@orangewolf orangewolf deleted the i543-env-vars branch September 22, 2023 19:43
ShanaLMoore pushed a commit that referenced this pull request Jul 17, 2024
📚 Doc two different methods for getting started
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants