-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace SETTINGS_ env vars #2
Conversation
Compared to hyku readme, as well as other repos based on a more current Hyku to rename and/or remove settings vars. Also alphabetized Hyku vars to simplify side-by-side comparisons.
value: "true" | ||
- name: SETTINGS__MULTITENANCY__DEFAULT_HOST | ||
value: "%{tenant}.s2.adventistdigitallibrary.org" | ||
- name: SETTINGS__MULTITENANCY__ENABLED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious if there's there's an equivalent HYKU setting for this? Or does it just go away now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they go away
value: hyku-adventist-dev | ||
- name: SETTINGS__ZOOKEEPER__CONNECTION_STR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing here
Looks good, i left just some questions |
📚 Doc two different methods for getting started
Story
Refs #538
Expected Behavior Before Changes
Files in /ops directory contained SETTINGS_ vars
Expected Behavior After Changes
All references to SETTINGS_ vars in are replaced or removed.
Screenshots / Video
Notes
THERE APPEARS TO BE NO HYKU EQUIVALENTS FOR