Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Change indexing for issue_number #828

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

kirkkwang
Copy link
Contributor

@kirkkwang kirkkwang commented Sep 26, 2024

Originally changed because it matches Adventist prior to Valkyrie, but it seems to be causing issues so I'm changing it to _tesim.

Ref #822

Originally changed because it matches Adventist prior to Valkyrie, but
it seems to be causing issues so I'm changing it to _tesim.
@ShanaLMoore
Copy link

ShanaLMoore commented Sep 26, 2024

hm, now I'm confused. She created a new collection. if this is the property that prod has I wonder if or how this change will impact existing prod data.

Copy link
Contributor

@laritakr laritakr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In current knapsack, this is indexed as issue_number_tesim, so this seems correct to me.

@kirkkwang kirkkwang merged commit 5b79bcd into main Sep 26, 2024
6 checks passed
@kirkkwang kirkkwang deleted the fix-issue-number-indexing branch September 26, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants