Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☄ [EPIC:] Fix Specs related to upgrading rails/hyrax #55

Closed
7 of 9 tasks
ShanaLMoore opened this issue Aug 8, 2023 · 2 comments
Closed
7 of 9 tasks

☄ [EPIC:] Fix Specs related to upgrading rails/hyrax #55

ShanaLMoore opened this issue Aug 8, 2023 · 2 comments
Milestone

Comments

@ShanaLMoore
Copy link

ShanaLMoore commented Aug 8, 2023

User Story

related #23

Using dual boot we upgraded rails to 6.1 and Hyrax to 4.0.

related:

To see what specs are failing, run the rspec command with the bootboot env var:

DEPENDENCIES_NEXT=1 bundle exec rspec spec

Additional Information

After getting the total amount of failures, consider breaking them up into groups so that the team can divide and conquer to resolve them:

NEEDS DISCUSSION

  • Specs related to 'uninitialized constant AAPB::BatchIngest::PBCoreXMLItemIngester::PowerConverter' (ie: ./spec/services/aapb/batch_ingest/pbcore_xml_item_ingester_spec.rb:4) <= THIS MAY BE A MOOT ISSUE IF THE CLIENT AGREES TO FULLY ADOPT BULKRAX we have currently skipped these for rails 6.1

etc...

Done Looks Like

  • Entire spec suite passes for rails 6_1

Specs (ran locally)

Failures

https://gist.github.com/kirkkwang/368c818e5f8a1ec9020bbe28699ca127

Details

https://gist.github.com/kirkkwang/7976eafb2c0cd289a9c796778ba8cc9b

@ShanaLMoore ShanaLMoore added the blocked other work must be completed first label Aug 8, 2023
@ShanaLMoore ShanaLMoore changed the title Fix Failing Specs Fix Failing Specs related to upgrading rails/hyrax Aug 8, 2023
@ShanaLMoore ShanaLMoore removed the blocked other work must be completed first label Aug 9, 2023
@jillpe jillpe added blocked other work must be completed first and removed blocked other work must be completed first labels Aug 10, 2023
@jillpe
Copy link

jillpe commented Aug 10, 2023

blocked by #60

@ShanaLMoore ShanaLMoore changed the title Fix Failing Specs related to upgrading rails/hyrax ✅ Fix Failing Specs related to upgrading rails/hyrax Aug 11, 2023
@ShanaLMoore ShanaLMoore changed the title ✅ Fix Failing Specs related to upgrading rails/hyrax Fix Failing Specs related to upgrading rails/hyrax Aug 11, 2023
@ShanaLMoore ShanaLMoore changed the title Fix Failing Specs related to upgrading rails/hyrax ☄ Fix Failing Specs related to upgrading rails/hyrax Aug 11, 2023
@ShanaLMoore ShanaLMoore changed the title ☄ Fix Failing Specs related to upgrading rails/hyrax ☄ [EPIC:] Fix Failing Specs related to upgrading rails/hyrax Aug 11, 2023
@ShanaLMoore ShanaLMoore changed the title ☄ [EPIC:] Fix Failing Specs related to upgrading rails/hyrax ☄ [EPIC:] Fix Specs related to upgrading rails/hyrax Aug 11, 2023
@ShanaLMoore ShanaLMoore added the needs discussion has open questions or need for discussion label Aug 11, 2023
@ShanaLMoore
Copy link
Author

ShanaLMoore commented Aug 11, 2023

Update: Local specs run from develop

Finished in 22 minutes 47 seconds (files took 18.62 seconds to load)
631 examples, 45 failures, 39 pending

@jillpe jillpe added this to the Hyrax Upgrade milestone Aug 15, 2023
@ShanaLMoore ShanaLMoore removed needs discussion has open questions or need for discussion blocked other work must be completed first labels Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants