Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve spec error: 'The asset ".png" is not present in the asset pipeline.' #65

Closed
2 tasks done
Tracked by #55
ShanaLMoore opened this issue Aug 10, 2023 · 0 comments
Closed
2 tasks done
Tracked by #55

Resolve spec error: 'The asset ".png" is not present in the asset pipeline.' #65

ShanaLMoore opened this issue Aug 10, 2023 · 0 comments
Assignees
@kirkkwang
Labels
not end user testable this ticket can be closed after verified by a dev

Comments

@ShanaLMoore
Copy link

ShanaLMoore commented Aug 10, 2023 •
edited by kirkkwang
Loading

Summary

majority of the specs are failing due to error 'The asset ".png" is not present in the asset pipeline.'

This ticket is to resolve those errors only and merge that fix back into develop. If resolving that error does not make the specs pass, that's another ticket.

related to:

Acceptance Criteria

  • We should be able to run the spec suite without error 'The asset ".png" is not present in the asset pipeline.'
    • Resolve the error and make separate tickets if specs are still failing

Notes

Specs (ran locally)

Failures

https://gist.github.com/kirkkwang/368c818e5f8a1ec9020bbe28699ca127

Details

https://gist.github.com/kirkkwang/7976eafb2c0cd289a9c796778ba8cc9b
@ShanaLMoore ShanaLMoore mentioned this issue Aug 10, 2023
Closed
9 tasks
kirkkwang added a commit to WGBH-MLA/ams that referenced this issue Aug 11, 2023
@kirkkwang
✅ Get ".png" specs passing in Hyrax 4.0
82885c4 
This commit will refactor the `WorkThumbnailPathService` away from the
`class << self` pattern to a more standard `def self.method_name`
pattern because it seems to not work as expected in Rails 6.1.  This
commit also fixes `Hyrax::Workflow::WorkflowFactoryDecorator` to use
`work.admin_set.active_workflow` instead of `work.active_workflow`
because in Hyrax 4.0 because Hyrax::InAdminSet mixin has been deprecated
Instead #active_workflow is now a method on the AdminSet model.

Ref:
  - samvera/hyrax@e3c0e52
  - notch8#65
@kirkkwang kirkkwang mentioned this issue Aug 11, 2023
Merged
@ShanaLMoore ShanaLMoore added the not end user testable this ticket can be closed after verified by a dev label Aug 11, 2023
@ShanaLMoore ShanaLMoore changed the title fix specs related to 'The asset ".png" is not present in the asset pipeline.' (ie: asset_indexer_spec => fails on line 11) fix specs related to 'The asset ".png" is not present in the asset pipeline.' Aug 11, 2023
@ShanaLMoore ShanaLMoore changed the title fix specs related to 'The asset ".png" is not present in the asset pipeline.' Resolve spec error: 'The asset ".png" is not present in the asset pipeline.' Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirkkwang kirkkwang

Labels
not end user testable this ticket can be closed after verified by a dev
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ShanaLMoore @kirkkwang