🎁 Adding logging for PDF splitting information #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyf
force-pushed
the
adding-logging-to-pdf-splitter
branch
from
3acfe47 to
0ba3195
Compare
orangewolf
reviewed
Jul 14, 2023
| @@ -106,7 +106,7 @@ def generated_files | |||
| @generated_files << if generated_file.exist? | |||
| generated_file | |||
| else | |||
| log_message = "#{self.class}#generated_files :: " \ | |||
| log_message = "🤠🐮 #{self.class}#generated_files :: " \ | |||
There was a problem hiding this comment.
emoji break in k8s logging tools. I know they are fun, but can we skip them for the sake of consistency?
There was a problem hiding this comment.
sigh I'll remove them. They aren't just fun, they are helpful to quick scan.
Prior to this commit, during run time we didn't have much insight as to whether or not we were finding the split pages (and if so how many). With this commit we log information regarding the number of files we find, the path/index for each one OR if we're generating our own. Related to: - #56
jeremyf
force-pushed
the
adding-logging-to-pdf-splitter
branch
from
0ba3195 to
0b924b1
Compare
jeremyf
added a commit
to notch8/iiif_print
that referenced
this pull request
Jul 14, 2023
> emoji break in k8s logging tools. Related to: - notch8/derivative_rodeo#63
kirkkwang
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, during run time we didn't have much insight as to whether or not we were finding the split pages (and if so how many).
With this commit we log information regarding the number of files we find, the path/index for each one OR if we're generating our own.
Related to: