Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bulkrax Imports for IiifPrint PDF splitting #128

Merged
merged 5 commits into from
Feb 15, 2023
Merged

Fix Bulkrax Imports for IiifPrint PDF splitting #128

merged 5 commits into from
Feb 15, 2023

Conversation

laritakr
Copy link
Contributor

@laritakr laritakr commented Feb 9, 2023

Ref #97 and #98

Adds FileSetActorDecorator to add IiifPrint splitting ability for Bulkrax imports:

  • Supports importing files from separate row of CSV and splitting to child works.
  • Supports importing from remote urls from separate row of CSV and splitting to child works.

Notes:

  • Bulkrax has not worked for remote urls in same row as parent. If this is implemented, it should also work for IiifPrint.
  • Bulkrax previously worked to split works for uploaded files in same row as parent.

LaRita Robinson added 3 commits February 9, 2023 16:25
Adds FileSetActorDecorator to add IiifPrint splitting ability for Bulkrax imports:
* Supports importing files from separate row of CSV and splitting to child works.
* Supports importing from remote urls from separate row of CSV and splitting to child works.

Notes:
* Bulkrax has not worked for remote urls in same row as parent. If this is implemented, it should also work for IiifPrint.
* Bulkrax previously worked to split works for uploaded files in same row as parent.
Create new service to share iiif print splitting logic.
@laritakr
Copy link
Contributor Author

Created work from file.zip

Screenshot 2023-02-10 at 6 21 14 PM

Created work from i97-sample-remote-fileset.csv

Screenshot 2023-02-10 at 6 21 03 PM

@laritakr laritakr marked this pull request as ready for review February 10, 2023 23:48
@laritakr
Copy link
Contributor Author

Test via hyku branch i98-iiif-print-fileset-row at samvera/hyku#1912

Copy link
Contributor

@jeremyf jeremyf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic!

@laritakr laritakr merged commit 8d1309f into main Feb 15, 2023
@laritakr laritakr deleted the i98-bulkrax branch February 15, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants