Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting to generator #143

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Add linting to generator #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions lib/generators/iiif_print/install_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,24 @@ def inject_configuration
def inject_assets
generate 'iiif_print:assets'
end

# Blacklight IIIF Search generator has some linting that does not agree with CircleCI on Hyku
# ref https://github.com/boston-library/blacklight_iiif_search/blob/v1.0.0/lib/generators/blacklight_iiif_search/controller_generator.rb
# the follow two methods does a clean up to appease Rubocop
def lint_catalog_controller
file = "app/controllers/catalog_controller.rb"
contents = File.read(file)
contents.gsub!(/\n\s*\n\s*# IiifPrint index fields/, "\n # IiifPrint index fields")
contents.gsub!(/\n\s*\n\s*# configuration for Blacklight IIIF Content Search/, "\n\n # configuration for Blacklight IIIF Content Search")
File.write(file, contents)
end

# ref https://github.com/boston-library/blacklight_iiif_search/blob/v1.0.0/lib/generators/blacklight_iiif_search/templates/iiif_search_builder.rb
def lint_iiif_search_builder
file = "app/models/iiif_search_builder.rb"
contents = File.read(file)
contents.insert(0, "# frozen_string_literal: true\n\n")
File.write(file, contents)
end
end
end