Allinson flex support #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented a sql query to pull labels and names from `AllinsonFlex::ProfileProperty` so all defined m3 metadata can be displayed.
This commit refactors the sql query into an ActiveRecord query but left notes just in case we need it again later.
Instead of creating new solr documents, this commit will find existing solr documents to use. Also adding support for solr documents that do not have the methods like `#title` and instead use `['title_tesim']`.
The failing spec revealed some inefficiencies and those were addressed in this commit.
kirkkwang
force-pushed
the
allinson-flex-support
branch
from
0337694 to
551017f
Compare
This commit will clean up the AR query and rename the properties more semantically in a later step. `value` becomes `label` and `indexing` becomes `options` in `.allinson_flex_fields_for`.
laritakr
reviewed
Mar 10, 2023
laritakr
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Allinson Flex metadata
Implemented a sql query to pull labels and names from
AllinsonFlex::ProfilePropertyso all defined m3 metadata can bedisplayed.
Refactor SQL to ActiveRecord
This commit refactors the sql query into an ActiveRecord query but left
notes just in case we need it again later.
Optimize solr query
Instead of creating new solr documents, this commit will find existing
solr documents to use. Also adding support for solr documents that do
not have the methods like
#titleand instead use['title_tesim'].Fix specs and refactor
The failing spec revealed some inefficiencies and those were addressed
in this commit.