[i335] - port over serverless code from nnp #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terBehavior TODO: Loading issue in dev; when we change code the app no longer hits our iiif_manifest_presenter_behavior.rb and reverts back to using the app instead of cloudfront. We also added the prepend in the after_intitialize because the app couldn't find the digest method otherwise.
This commit will add a test for #display_image. Also, a refactor was introduced to account for both Hyrax 2 and 3. The method signature of the `Hyrax.config.iiif_image_url_builder` lambda changed to add an additional argument in Hyrax 3. ref: https://github.com/samvera/hyrax/blob/2.x-stable/lib/hyrax/configuration.rb#L397-L399 ref: https://github.com/samvera/hyrax/blob/3.x-stable/lib/hyrax/configuration.rb#L250-L252
ShanaLMoore
requested review from
jeremyf,
laritakr and
orangewolf
and removed request for
jeremyf
jeremyf
approved these changes
Mar 23, 2023
orangewolf
requested changes
Mar 23, 2023
kirkkwang
force-pushed
the
i335-import-nnp-serverless-code-into-iiif-print
branch
2 times, most recently
from
3d31203 to
ac3edcf
Compare
This commit will add OVERRIDE comments where useful and add a blurb in the README for this new feature. The #display_content method was added to support presentation 3 manifests. `SERVERLESS` has been renamed to `EXTERNAL`. `DisplayImagePresenterBehavior` has beeen refactored to incorporate existing code. Specs have also been refactored.
kirkkwang
force-pushed
the
i335-import-nnp-serverless-code-into-iiif-print
branch
from
ac3edcf to
4a08e55
Compare
orangewolf
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ref: notch8/britishlibrary#335
This PR allows iiif_print to support iiif external image servers
Screenshots / Video
Expected Behavior
TODO:
There's a loading issue in dev; when we change code the app no longer hits our iiif_manifest_presenter_behavior.rb it reverts back to using the app instead of cloudfront. This seems to only impact dev but it's really annoying.
We also added the DisplayImagePresenterBehavior prepend in the after_intitialize because the app couldn't find the digest method otherwise.
We will also need to figure out how to make serverless iiif work for audio/video files.