Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guard to method #213

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Conversation

laritakr
Copy link
Contributor

@laritakr laritakr commented Apr 7, 2023

This is an edge case, but prevents a manifest failure. Previously we got an error because of calling IiifPrint.manifest_metadata_from(work: image, presenter: presenter) when image was nil.

Before & After Screenshots

Before:

Screenshot 2023-04-07 at 11 44 42 AM

After:

Screenshot 2023-04-07 at 11 43 32 AM

Testing Instructions

  1. Add a new work with an image file.
  2. When viewing the above work, add a child work as a child using the Attach Child dropdown option. Use a PDF file for this child's file.
  3. When returning to the original work, universal viewer should show both the original image and all of the child work's split child work images.

Previously we got an error because of calling `IiifPrint.manifest_metadata_from(work: image, presenter: presenter)` when image was nil.
Copy link
Contributor

@kirkkwang kirkkwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@laritakr laritakr merged commit 487cf53 into main Apr 7, 2023
@laritakr laritakr deleted the add-guard-to-manifest-metadata-method branch April 7, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants