Search parent metadata instead of no match found #234
Conversation
This commit will override `BlacklightIiifSearch::IiifSearch#solr_params` to include the parent metadata fields in a UV search.
kirkkwang
changed the title
BlacklightIiifSearch::IiifSearch
| return { q: 'nil:nil' } unless q | ||
|
|
||
| { | ||
| q: "#{q} AND (#{iiif_config[:object_relation_field]}:\"#{parent_document.id}\" OR id:\"#{parent_document.id}\")", |
There was a problem hiding this comment.
What happens if we don't have a parent_document? What happens if iiif_config doesn't have the key :object_relation_field or if iiif_config[:object_relation_field] is nil?
There was a problem hiding this comment.
It seems like not having a parent_document should never happen because the work itself comes in as its own parent even when looking at a work that has no parent/child relationships.
if iiif_config lost its :object_relation_field or if iiif_config[:object_relation_field] is nil, then most likely someone altered the code from the generator. I think maybe we need to raise an error at that point.
There was a problem hiding this comment.
I tried commenting out the :object_relation_field and it does not cause a crash. This however seems like a programmer if the :object_relation_field is missing (since it comes in through the generator). I'm rethinking if we need to raise an error just to account for this scenario.
ref: notch8/essi#23, notch8/essi#24
This commit will override
BlacklightIiifSearch::IiifSearch#solr_paramsto include the parent metadata fields in a UV search.