Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor IIIF Print Upload Actor #24

Merged
merged 2 commits into from
Dec 13, 2022
Merged

Refactor IIIF Print Upload Actor #24

merged 2 commits into from
Dec 13, 2022

Conversation

laritakr
Copy link
Contributor

Ref #7

  • Refactor IiifPrintUploadActor
  • Create IiifPrintBehavior module
  • Rename CreateIssuePagesJob to CreatePagesJob
  • Passing specs for IiifPrintUploadActor & IiifPrintBehavior

LaRita Robinson added 2 commits December 12, 2022 17:07
Refactor actor
Rename create pages job
Add iiif_print_behavior module to add IiifPrint features by including in a work model.
@laritakr laritakr changed the title Upload actor i7 Refactor IIIF Print Upload Actor Dec 12, 2022
@laritakr
Copy link
Contributor Author

rspec ./spec/models/concerns/iiif_print/iiif_print_behavior_spec.rb
Screenshot 2022-12-12 at 6 07 35 PM

rspec ./spec/actors/iiif_print/actors/iiif_print_upload_actor_spec.rb
Screenshot 2022-12-12 at 6 08 52 PM

@laritakr laritakr merged commit 20425eb into main Dec 13, 2022
@laritakr laritakr deleted the upload-actor-i7 branch December 13, 2022 16:27
@kirkkwang kirkkwang linked an issue Dec 24, 2022 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refacor IiifPrint::Actors::IiifPrintUploadActor
3 participants