🐛 Fix additional query terms removal #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will fix the removal of the additional query terms. Here we use a regular expression to remove the additional query terms from the query string instead of using the `gsub` method. This is more accurate because it was noticed that `document['is_page_of_ssim']` isn't always what we expect. It does not work in a nested work context.
jeremyf
approved these changes
May 17, 2023
kirkkwang
force-pushed
the
fix-additiona-query-terms
branch
from
d2caee2 to
d35889b
Compare
kirkkwang
force-pushed
the
fix-additiona-query-terms
branch
from
d35889b to
d57397b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will fix the removal of the additional query terms. Here we use a regular expression to remove the additional query terms from the query string instead of using the
gsubmethod. This is more accurate because it was noticed thatdocument['is_page_of_ssim']isn't always what we expect. It does not work in a nested work context.