Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I10 replace indexes relationships with lv implementation #25

Merged

Conversation

ShanaLMoore
Copy link
Contributor

@ShanaLMoore ShanaLMoore commented Dec 13, 2022

Port over the following from Louisville. It should replace iiif_print's indexes_relationship.rb

  • set_child_works.rake from lousiville

  • port lib/rdf/custom_is_child_term.rb from Louisville

  • port app/models/concerns/set_child_flag to a mixin, include in work types

  • get app/indexers/hyrax/file_set_indexer and put it in a mixin, include in file_set_indexer

  • get all_decendant-file_sets and ancestor_ids from app/indexers/app_index.rb and put it in an indexer mixin

  • specs: Time boxed it - will create a ticket to revisit them later on. Currently I'm unable to test this in the UI but this otherwise is what LV has. ref: Clean up specs #43

  • tested generator behaves as expected

  • manually verified the relationships get formed

  • child's is_child_bsi is set to true as seen in the solr dashboard. is_page_of_ssim is populated, which proves the ancestor method works.
    image

  • forms relationship w bulkrax importer

  • sample file: iiif_print_test.zip
    image

  • catalog should only display parents

image

child view
image

  • thumbnail does not render due to WIP. (newspaper page model has been removed) - to be handled in a separate ticket

image

  • parent's manifest.json includes child's id (90f946ef-519e-42d7-ae7f-af77466143b1)

image

  • able to run rake task
  • verify generator looks OK (it may need changes later - i created a ticket to review this towards the end of the project when all the moving pieces settle)

@ShanaLMoore ShanaLMoore marked this pull request as ready for review December 15, 2022 21:09
@ShanaLMoore ShanaLMoore marked this pull request as draft December 16, 2022 00:32
@ShanaLMoore ShanaLMoore marked this pull request as ready for review December 16, 2022 23:07
@@ -0,0 +1,150 @@
# frozen_string_literal: true
Copy link
Contributor Author

@ShanaLMoore ShanaLMoore Dec 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO - create a separate ticket to revisit the UV manifest. This one is taken from LV hyrax 2.9.6 so it'll prob need to be updated.

This is responsible for displaying the children in the uv and its metadata.

Copy link
Contributor

@kirkkwang kirkkwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@ShanaLMoore ShanaLMoore merged commit f19145e into main Dec 20, 2022
@ShanaLMoore ShanaLMoore deleted the i10-replace-indexes-relationships-with-LV-implementation branch January 4, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants