move everything to the established decorator pattern #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangewolf
changed the title
5 tasks
|
related slack convo: https://assaydepot.slack.com/archives/C0313NK5NMA/p1718378012527019 |
…corator-out-of-engine Move solr document decorator out of engine
We no longer support Active Fedora in v2.0+ so this method call needs to be replaced.
This manifested as a failed derivatives job that ultimately did not display thumbnails. We need to return early whenever content isn't present to prevent this.
kirkkwang
approved these changes
Jul 3, 2024
kirkkwang
force-pushed
the
more_decorators_than_hgtv
branch
from
b16897f to
c0f920f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the decorator pattern so that Rails loading is handled correctly.
note this code has not been tested yet