A few bug fixes #354
Merged
A few bug fixes #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If ever the original_file hasn't been set, we want to guard against a NoMethodError for NilClass.
Because we have the form keys when the work gets created, `is_child` is set to `''` and not `nil`. This causes any queries that look for `is_child` being `nil` to not work.
ShanaLMoore
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Add guard for nil original_file
21100a9
If ever the original_file hasn't been set, we want to guard against a
NoMethodError for NilClass.
🐛 Remove form keys from is_child
2e4af92
Because we have the form keys when the work gets created,
is_childisset to
''and notnil. This causes any queries that look foris_childbeingnilto not work.