Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i44] add build-test-lint.yaml #46

Merged
merged 4 commits into from
Dec 22, 2022
Merged

[i44] add build-test-lint.yaml #46

merged 4 commits into from
Dec 22, 2022

Conversation

ShanaLMoore
Copy link
Contributor

@ShanaLMoore ShanaLMoore commented Dec 20, 2022 •
edited
Loading

Thanks for your guidance @aprilrieger 🎉

image

PS. The test passing is misleading and does not reflect the actual status of the spec suite

@ShanaLMoore ShanaLMoore reopened this Dec 21, 2022
@ShanaLMoore ShanaLMoore mentioned this pull request Dec 21, 2022
Closed
kirkkwang
kirkkwang approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@kirkkwang kirkkwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks really cool, glad you got this working!

@ShanaLMoore ShanaLMoore merged commit 68ea92c into main Dec 22, 2022
@ShanaLMoore ShanaLMoore deleted the i44-add-build-test-link-yaml branch January 4, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirkkwang kirkkwang kirkkwang approved these changes

@aprilrieger aprilrieger Awaiting requested review from aprilrieger

Assignees
No one assigned
Labels
major-ver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShanaLMoore @kirkkwang @AKFosterDev