Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i30] - port over rake tasks from LV #47

Merged
merged 2 commits into from
Dec 22, 2022
Merged

[i30] - port over rake tasks from LV #47

merged 2 commits into from
Dec 22, 2022

Conversation

ShanaLMoore
Copy link
Contributor

@ShanaLMoore ShanaLMoore commented Dec 21, 2022 •
edited
Loading

Summary

  • made adjustments to the set_child_works rake task. It was previously copied over in an earlier PR.
  • ported over the set_parent_thumbnail rake task from LV

Acceptance Criteria

If a parent doesn't have a thumbnail, running this rake task will set its thumbnail to be its child's first file_set (currently ordered by source identifier, as that was the requirement set in LV). This may change later.

This rake task was originally created as a backup fix, for when the SetParentThumbnailJob doesn't complete for whatever reason.

command: rake iiif_print:update:set_parent_thumbnail

Screenshots

BEFORE

image

AFTER

image

kirkkwang
kirkkwang approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@kirkkwang kirkkwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! i like the refactor for set child works

@ShanaLMoore ShanaLMoore merged commit 53fddb7 into main Dec 22, 2022
@ShanaLMoore ShanaLMoore deleted the i30-port-over-rake-tasks-from-LV branch January 4, 2023 19:38
ShanaLMoore added a commit that referenced this pull request Jan 16, 2023
@ShanaLMoore
Revert "[i30] - port over rake tasks from LV (#47)"
aab670a 
This reverts commit 53fddb7.
ShanaLMoore pushed a commit that referenced this pull request Jan 17, 2023
Revert "[i30] - port over rake tasks from LV (#47)" (#69)
ecd73c0 
* Revert "[i30] - port over rake tasks from LV (#47)"

This reverts commit 53fddb7.

* revert back to main

* lint: rubocop fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirkkwang kirkkwang kirkkwang approved these changes

Assignees
No one assigned
Labels
major-ver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShanaLMoore @kirkkwang @AKFosterDev