Moving services from app directory to lib #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no compelling reason for these to be part of the app directory. And that makes requiring them for isolated tests a bit trickery. With this change, we don't need to load the Rails engine to "auto-load" the underlying services. Ideally, these would be in the IiifPrint::Services namespace; but that's perhaps more than we want to do.
jeremyf
force-pushed
the
moving-services-from-app-to-lib
branch
from
0124b08 to
8b9e26b
Compare
kirkkwang
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no compelling reason for these to be part of the app directory. And that makes requiring them for isolated tests a bit trickery.
With this change, we don't need to load the Rails engine to "auto-load" the underlying services.
Ideally, these would be in the IiifPrint::Services namespace; but that's perhaps more than we want to do.