-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to sort works and collections on dashboard #748
Comments
Do you have a preference on where the sort button should go? Or do you want a developer to decide? |
I think the space between Show # per page and Search makes sense, if that's an option |
This commit will add the ability to sort collections on the dashboard. The collections work differently than the works so we have to make sure the sort field is added to the search builder. Because when you click into a collection can view the works attached to the collection, we have to approach it differently because otherwise the sort fields from the dashboard index page will also be applied to the show page. We decorate Blacklight helpers to check the controller action name as our conditional. Ref: - #748
QA RESULTS: Pass ✅Tested on: https://dev.commons-archive.org/dashboard/my/collections?locale=en COLLECTIONS
[ ] - date uploaded
[x] - date modified Demo: https://share.zight.com/o0uKe9nO WORKS
|
Why is date uploaded missing from the collection dashboard? Per @kirkkwang - # Collections don't seem to have a date_uploaded_dtsi nor date_modified_dtsi
# we can at least use the system_modified_dtsi instead of date_modified_dtsi
# but we will omit date_uploaded_dtsi |
Requires re-indexing prod. Hold on client verification until that task is complete. |
Sort by Depositor and Creator aren't working in production tenants I've tested. Depositor sorts by title, and Creator seems to sort by some combination of file type and title. |
Apologies for dropping the ball with removing the ON HOLD label. According to this comment the prod data was re-indexed. So I'll take a few mins to look into what may be going on. @ndroark |
@ShanaLMoore I don't think we ever did a reindex on prod did we? |
Shana said we did reindex prod, and it's also not working right on staging. |
@ndroark Could you provide a screenshot or url, that shows the sort behaving incorrectly? Could you also specify your expectation in comparison to what your screenshot shows? |
Update after a huddle meeting: Creator is OK but depositor is not. Depositor had a typo in the app indexer so we will fix this, redeploy and reindex prod to resolve this. |
deployed hotfix to prod. Don't client verify this until the reindex has been completed. Since it's not urgent I may wait until the weekend to reindex cc @ndroark |
This commit will allow us to override the CollectionsController instead of the Blacklight::ConfigurationHelperBehavior. A bug was noticed when switching the sort fields that the field selected wouldn't stick in the UI even though the fields were actually sorting correctly. Overriding the CollectionsController will be a better pattern since we override the WorksController in the same way. The reason why we didn't do that in the first place was because it caused the show page to have the same sort fields as the index page. In this commit, we are also modifying the show page to reconfigure the sort fields to address the issue. Ref: - #748
Reindex complete ✅ @kirkkwang to review work in prod then let @ndroark know to do the same if everything functions ok. |
Contribute back the following features: - notch8/palni-palci#445 - notch8/palni-palci#659 - notch8/palni-palci#740 - notch8/palni-palci#748 - notch8/palni-palci#823 - notch8/palni-palci#843 - notch8/palni-palci#844 - notch8/palni-palci#911 Which were resolved via the following PRs: - notch8/palni-palci#920 - notch8/palni-palci#704 - notch8/palni-palci#706 - notch8/palni-palci#790 - notch8/palni-palci#867 - notch8/palni-palci#874 - notch8/palni-palci#893 - notch8/palni-palci#898 - notch8/palni-palci#824 - notch8/palni-palci#923 - notch8/palni-palci#939 - notch8/palni-palci#922 - notch8/palni-palci#926 - notch8/palni-palci#927 - notch8/palni-palci#928 - notch8/palni-palci#929 - notch8/palni-palci#930 - notch8/palni-palci#931 - notch8/palni-palci#943 - notch8/palni-palci#945 - notch8/palni-palci#954 Co-authored-by: Lea Ann Bradford <[email protected]> Co-authored-by: LaRita Robinson <[email protected]> Co-authored-by: Kirk Wang <[email protected]> Co-authored-by: Shana Moore <[email protected]>
Contribute back the following features: - notch8/palni-palci#445 - notch8/palni-palci#659 - notch8/palni-palci#740 - notch8/palni-palci#748 - notch8/palni-palci#823 - notch8/palni-palci#843 - notch8/palni-palci#844 - notch8/palni-palci#911 Which were resolved via the following PRs: - notch8/palni-palci#920 - notch8/palni-palci#704 - notch8/palni-palci#706 - notch8/palni-palci#790 - notch8/palni-palci#867 - notch8/palni-palci#874 - notch8/palni-palci#893 - notch8/palni-palci#898 - notch8/palni-palci#824 - notch8/palni-palci#923 - notch8/palni-palci#939 - notch8/palni-palci#922 - notch8/palni-palci#926 - notch8/palni-palci#927 - notch8/palni-palci#928 - notch8/palni-palci#929 - notch8/palni-palci#930 - notch8/palni-palci#931 - notch8/palni-palci#943 - notch8/palni-palci#945 - notch8/palni-palci#954 Co-authored-by: Lea Ann Bradford <[email protected]> Co-authored-by: LaRita Robinson <[email protected]> Co-authored-by: Kirk Wang <[email protected]> Co-authored-by: Shana Moore <[email protected]>
Contribute back the following features: - notch8/palni-palci#445 - notch8/palni-palci#659 - notch8/palni-palci#740 - notch8/palni-palci#748 - notch8/palni-palci#823 - notch8/palni-palci#843 - notch8/palni-palci#844 - notch8/palni-palci#911 Which were resolved via the following PRs: - notch8/palni-palci#920 - notch8/palni-palci#704 - notch8/palni-palci#706 - notch8/palni-palci#790 - notch8/palni-palci#867 - notch8/palni-palci#874 - notch8/palni-palci#893 - notch8/palni-palci#898 - notch8/palni-palci#824 - notch8/palni-palci#923 - notch8/palni-palci#939 - notch8/palni-palci#922 - notch8/palni-palci#926 - notch8/palni-palci#927 - notch8/palni-palci#928 - notch8/palni-palci#929 - notch8/palni-palci#930 - notch8/palni-palci#931 - notch8/palni-palci#943 - notch8/palni-palci#945 - notch8/palni-palci#954 Co-authored-by: Lea Ann Bradford <[email protected]> Co-authored-by: LaRita Robinson <[email protected]> Co-authored-by: Kirk Wang <[email protected]> Co-authored-by: Shana Moore <[email protected]>
Contribute back the following features: - notch8/palni-palci#445 - notch8/palni-palci#659 - notch8/palni-palci#740 - notch8/palni-palci#748 - notch8/palni-palci#823 - notch8/palni-palci#843 - notch8/palni-palci#844 - notch8/palni-palci#911 Which were resolved via the following PRs: - notch8/palni-palci#920 - notch8/palni-palci#704 - notch8/palni-palci#706 - notch8/palni-palci#790 - notch8/palni-palci#867 - notch8/palni-palci#874 - notch8/palni-palci#893 - notch8/palni-palci#898 - notch8/palni-palci#824 - notch8/palni-palci#923 - notch8/palni-palci#939 - notch8/palni-palci#922 - notch8/palni-palci#926 - notch8/palni-palci#927 - notch8/palni-palci#928 - notch8/palni-palci#929 - notch8/palni-palci#930 - notch8/palni-palci#931 - notch8/palni-palci#943 - notch8/palni-palci#945 - notch8/palni-palci#954 Co-authored-by: Lea Ann Bradford <[email protected]> Co-authored-by: LaRita Robinson <[email protected]> Co-authored-by: Kirk Wang <[email protected]> Co-authored-by: Shana Moore <[email protected]>
Summary
Pals would like the ability to sort works and collections on the dashboard. They would like to be able to sort both by:
Screenshots
Accepted Criteria
date uploaded,date modified
,date created
,depositor (a-z)
, andcreator (a-z)
date uploaded
,date modified
,date created
,depositor (a-z)
, andcreator (a-z)
The text was updated successfully, but these errors were encountered: