Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with catalog gallery view #174

Closed
1 of 8 tasks
Tracked by #170
laritakr opened this issue Dec 2, 2024 · 4 comments
Closed
1 of 8 tasks
Tracked by #170

Issues with catalog gallery view #174

laritakr opened this issue Dec 2, 2024 · 4 comments
Assignees

Comments

@laritakr
Copy link
Contributor

laritakr commented Dec 2, 2024

Story

Gallery view needs to be fixed. Changes should be made in Hyku and should carry up to Pals

Acceptance Criteria

View should match HykuCommons except for the bottom row not having an oversized item, a bug which has already been resolved.

Gallery view should:

  • have box around each item, not just thumbnail
  • align boxes both vertically & horizontally
  • have consistent spaces between boxes
  • have all thumbnails be the same height
  • titles should align
  • shorten long descriptions

In Pals only

  • Override Hyku's 4 columns in gallery to only use 3 in Pals.
  • Override Hyku so sitewide links do not have underlines

Screenshots / Video

Staging

Screenshot 2024-12-02 at 3 25 18 PM

Hyku commons

Screenshot 2024-12-02 at 3 25 31 PM

Testing Instructions and Sample Files

Notes

@laritakr laritakr changed the title Issues with catalog masonry view Issues with catalog gallery view Dec 2, 2024
@jillpe
Copy link

jillpe commented Jan 13, 2025

fixed in hyku. This will be dealing with the customization in pals

@kirkkwang
Copy link
Contributor

these following criteria are now actually standard in Hyrax which uses the Blacklight gallery gem

  • have box around each item, not just thumbnail
  • align boxes both vertically & horizontally
  • have consistent spaces between boxes
  • have all thumbnails be the same height
  • titles should align

If we want to change the defaults then that will take more overrides and maintenance. For now I am leaving it unless these changes are requested.

@kirkkwang kirkkwang self-assigned this Jan 17, 2025
kirkkwang added a commit that referenced this issue Jan 17, 2025
This commit will update the Hyku submodule which will bring in the fix
for the catalog gallery view.  Also, it removes the
truncate_and_iconify_auto_link method because it got contributes back to
Hyku.  We are also removing all the underline text decoration from the
a tags but keeping the underline for the hover and active effect.

Ref:
- #174
@sjproctor sjproctor moved this to SoftServ QA in PalsKnapsack Jan 23, 2025
@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Jan 29, 2025

QA RESULTS: ❌ Needs Rework

UPDATE: The following was tested using the Institutional repository theme. After switching to the cultural theme, the problems described below started working again.

cc @kirkkwang This visually looks good but I cannot paginate to the next page. Should that be a separate ticket or rework?
Update: I also can't seem to select any other view, or open facets. I'm going to punt this one back.

Image

Image

To add, I am not seeing the same behavior in hyku-demo. I wonder if this is because of a chosen theme - I'll try to match Hyku-demos's theme to see if it'll make a difference:

Image

tested on STAGING

HYKUCOMMONS

Image

STAGING

Gallery view should:

  • have box around each item, not just thumbnail
  • align boxes both vertically & horizontally
  • have consistent spaces between boxes
  • have all thumbnails be the same height
  • titles should align
  • shorten long descriptions

In Pals only

  • Override Hyku's 4 columns in gallery to only use 3 in Pals.
  • Override Hyku so sitewide links do not have underlines

Image

@ShanaLMoore ShanaLMoore added the needs rework issue needs additional work label Jan 29, 2025
@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Jan 29, 2025

Retesting all themes to see which one has the issues:

Default Repository ✅

Image

Cultural Repository ✅

Image

Institutional Repository ✅

Image

Neutral Repository ✅

Image

I can't explain the behavior reported above. Everything seems to be ok now after switching through the different themes. 🙃

QA RESULTS: ✅ PASS

@ShanaLMoore ShanaLMoore removed the needs rework issue needs additional work label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants