Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection Edit Form - Sharing tab, cannot add users and groups #51

Open
1 task
Tracked by #33
jillpe opened this issue May 31, 2024 · 7 comments
Open
1 task
Tracked by #33

Collection Edit Form - Sharing tab, cannot add users and groups #51

jillpe opened this issue May 31, 2024 · 7 comments
Assignees
Labels
bug something isn't working High Priority

Comments

@jillpe
Copy link

jillpe commented May 31, 2024

#Summary
Collection Edit Form - Sharing Tab

Adding groups and users does not work.

Screen.Recording.2024-05-31.at.2.13.18.PM.mov

Acceptance Criteria

  • I can add groups and users to a collection via the collection edit form
@jillpe jillpe changed the title Collection Edit Form - Sharing is not functional Collection Edit Form - Sharing tab, cannot add users and groups May 31, 2024
@ShanaLMoore ShanaLMoore added High Priority bug something isn't working labels Jun 3, 2024
@ShanaLMoore
Copy link
Contributor

The options as seen in the video produced the following error in the server:

image

@ShanaLMoore
Copy link
Contributor

permission_template_update_params =>
#<ActionController::Parameters {"access_grants_attributes"=>#<ActionController::Parameters {"0"=>#<ActionController::Parameters {"access"=>"false", "agent_id"=>"registered", "agent_type"=>"group"} permitted: true>} permitted: true>} permitted: true>

@ShanaLMoore
Copy link
Contributor

TODO: Fix failing specs

ShanaLMoore pushed a commit to notch8/hykuup_knapsack that referenced this issue Jun 17, 2024
this pulls in Hyku bug fixes:

- collection branding/alt text: #205
- collection sharing tab: unable to add users/groups: notch8/palni_palci_knapsack#51
@jillpe jillpe moved this to Deploy to Staging in PalsKnapsack Jun 17, 2024
@ShanaLMoore ShanaLMoore removed the needs rework issue needs additional work label Jun 18, 2024
@jillpe
Copy link
Author

jillpe commented Jun 18, 2024

SoftServ QA Findings:

Collection Tested

I can find users now, but clicking the 'Add' button does not add a user or group to the share settings

Screen.Recording.2024-06-18.at.1.46.39.PM.mov

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Jun 18, 2024

@jillpe I updated hyku up and not pals knapsack. Sorry about that, these days so many projects can be hard to juggle. I'll ping you again once I confirm the deploy, but we're blocked on deploying now because of GA4 issues so it may be a day or so.

@ShanaLMoore ShanaLMoore added the blocked other work must be completed first label Jun 18, 2024
ShanaLMoore pushed a commit that referenced this issue Jun 18, 2024
This will unblock QA from testing

Issue
- #51 (comment)
@ShanaLMoore ShanaLMoore removed the blocked other work must be completed first label Jun 20, 2024
@ShanaLMoore
Copy link
Contributor

unblocked. submodule has been updated and deployed.

@jillpe
Copy link
Author

jillpe commented Jun 21, 2024

SoftServ QA: ✅

Screen.Recording.2024-06-21.at.1.20.37.PM.mov

@jillpe jillpe moved this from Deploy to Staging to Client QA in PalsKnapsack Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working High Priority
Projects
Status: Deploy to Production
Development

No branches or pull requests

2 participants