Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some account settings not appearing for superadmins on tenant page #71

Open
7 tasks done
ndroark opened this issue Jun 9, 2024 · 3 comments
Open
7 tasks done

Some account settings not appearing for superadmins on tenant page #71

ndroark opened this issue Jun 9, 2024 · 3 comments
Assignees
@ShanaLMoore
Labels
High Priority

Comments

@ndroark
Copy link
Collaborator

ndroark commented Jun 9, 2024 •
edited by sjproctor
Loading

Some fields (such as OAI prefix, OAI sample Identifier, S3 Bucket) appear for superadmins in the current production tenant account settings page, but not on the Valkyrized page.

Current:

Image

Valkyrized test environment:

Image

notes

LaRita checked that these fields are available in hyku, so it must be a pals specific issue

Testing Instructions

visit staging
In the admin dashboard, click on Settings > Accounts
verify the following super admin settings are available:

When user has superadmin access

  • :analytics_provider,
  • :contact_email,
  • :file_acl,
  • :file_size_limit,
  • :oai_prefix,
  • :oai_sample_identifier,
  • :s3_bucket

When user does not have superadmin access. Admin user but not superadmin.

the above settings should not be displayed
@ndroark ndroark converted this from a draft issue Jun 9, 2024
@laritakr laritakr mentioned this issue Dec 3, 2024
Closed
19 tasks
@ShanaLMoore ShanaLMoore self-assigned this Jan 13, 2025
@ShanaLMoore ShanaLMoore moved this to In Development in PalsKnapsack Jan 13, 2025
@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Jan 13, 2025 •
edited
Loading

Hyku (hyku-demo)

Image

vs. Pals

Image

@ShanaLMoore ShanaLMoore moved this from In Development to Ready for Development in PalsKnapsack Jan 13, 2025
ShanaLMoore pushed a commit to samvera/hyku that referenced this issue Jan 14, 2025
Display superadmin settings when user has appropriate permissions
bb8a37a 
Issue:
- notch8/palni_palci_knapsack#71

Previously, superadmin settings like oai_prefix, oai_sample_identifier, and s3_bucket were being filtered out because public_settings wasn't taking the user's permissions into account, if set. This adds a permission check and passes it to public_settings to
dynamically show/hide superadmin settings based on user role.
@ShanaLMoore ShanaLMoore mentioned this issue Jan 14, 2025
Merged
@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Jan 14, 2025 •
edited
Loading

PALS has an account decorator with the following defined as super admin settings. These are the settings that are not being displayed even though the user is logged in as superadmin. The bug is because the hyku partial is not checking for user permissions, so it's is never showing super admin settings:

Account.superadmin_settings = %i[
  analytics_provider
  contact_email
  file_acl
  file_size_limit
  oai_prefix
  oai_sample_identifier
  s3_bucket
].freeze

ShanaLMoore pushed a commit that referenced this issue Jan 14, 2025
updates submodule
9a4a492 
Pulls in fix for missing superadmin settings in PALS.

ref:
- samvera/hyku#2411

Issue:
- #71
@ShanaLMoore ShanaLMoore mentioned this issue Jan 14, 2025
Merged
@sjproctor
Copy link
Contributor

sjproctor commented Jan 15, 2025 •
edited
Loading

QA Results: ✅ Pass

Process

Superadmin

  • Logged into an account that has a superadmin role
  • Dashboard > Settings > Accounts
  • Ensure the following are present
    • :analytics_provider
    • :contact_email
    • :file_acl
    • :file_size_limit
    • :oai_prefix
    • :oai_sample_identifier
    • :s3_bucket
Screen.Recording.2025-01-15.at.3.02.37.PM.mov

Regular Admin

  • Logged into an account that has an admin role
  • Dashboard > Settings > Accounts
  • Ensure the following are NOT present
    • :analytics_provider
    • :contact_email
    • :file_acl
    • :file_size_limit
    • :oai_prefix
    • :oai_sample_identifier
    • :s3_bucket
Screen.Recording.2025-01-15.at.3.07.41.PM.mov

@sjproctor sjproctor moved this from Ready for Development to Client QA in PalsKnapsack Jan 15, 2025
@ndroark ndroark moved this from Client QA to Deploy to Production in PalsKnapsack Jan 16, 2025
@laritakr laritakr moved this from Deploy to Production to Client Verification in PalsKnapsack Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShanaLMoore ShanaLMoore

Labels
High Priority
Projects
PalsKnapsack
Status: Client Verification
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ShanaLMoore @sjproctor @jillpe @ndroark