Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attach Child Work and Attach Image do not work #78

Open
7 tasks
ndroark opened this issue Jun 9, 2024 · 4 comments
Open
7 tasks

Attach Child Work and Attach Image do not work #78

ndroark opened this issue Jun 9, 2024 · 4 comments
Assignees
@kirkkwang
Labels
High Priority

Comments

@ndroark
Copy link
Collaborator

ndroark commented Jun 9, 2024 •
edited by jillpe
Loading

Summary

The "Attach Work" and "Attach Image" links appear when you click on the "Attach Child" button on while logged in on the work show page, but do not do anything when pressed. It should take the admin user to that work type's create new form.

In addition, it is missing all of the options, which should be 'Attach Work', 'Attach Image', 'Attach OER', 'Attach ETD', 'Attach CDL'

Screen.Recording.2024-06-20.at.9.02.53.AM.mov

Goal

Screen.Recording.2024-06-20.at.9.05.56.AM.mov

Acceptance Criteria

  • 'Attach Child' on a work show page has the following options:
    • Attach Work
    • Attach Image
    • Attach OER
    • Attach ETD
    • Attach CDL
  • Clicking the above options takes the admin user to the work type's create new form
@ndroark ndroark converted this from a draft issue Jun 9, 2024
@ShanaLMoore
Copy link
Contributor

Image
=> [GenericWork, Image, Etd, Oer]
CDL is missing

(byebug) Hyrax::ChildTypes.method(:for).source_location
["/app/samvera/hyrax-webapp/gems/hyrax/app/services/hyrax/child_types.rb", 27]

@kirkkwang kirkkwang self-assigned this Jun 21, 2024
kirkkwang pushed a commit to samvera/hyku that referenced this issue Jun 21, 2024
🐛 Fix Add Child link
cfdc1ec 
The links under the Add Child dropdown was not working because the HTML
structure was not correct.  This commit will close the button tag and
then open the ul tag which allows the links to be clickable.

Ref:
  - notch8/palni_palci_knapsack#78
@kirkkwang kirkkwang mentioned this issue Jun 21, 2024
Merged
@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Jun 25, 2024 •
edited
Loading

The link part of this ticket has been fixed but the drop down of all the work options is still a TODO (correct me if I'm wrong). So I'm going to move this ticket back to ready for dev. cc @kirkkwang

@ShanaLMoore
Copy link
Contributor

knapsack work types appear to be missing

@jillpe jillpe moved this to Client QA in PalsKnapsack Jul 15, 2024
@jillpe jillpe moved this from Client QA to SoftServ QA in PalsKnapsack Jul 15, 2024
@jillpe jillpe moved this from SoftServ QA to Deploy to Staging in PalsKnapsack Jul 15, 2024
@ShanaLMoore ShanaLMoore moved this from Deploy to Staging to SoftServ QA in PalsKnapsack Aug 5, 2024
@jillpe
Copy link

jillpe commented Aug 12, 2024

SoftServ QA: Pass ✅

Screen.Recording.2024-08-12.at.8.11.58.AM.mov

@jillpe jillpe moved this from SoftServ QA to Client QA in PalsKnapsack Aug 12, 2024
@laritakr laritakr moved this from Deploy to Production to Client Verification in PalsKnapsack Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirkkwang kirkkwang

Labels
High Priority
Projects
PalsKnapsack
Status: Client Verification
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ShanaLMoore @kirkkwang @jillpe @ndroark