Update submodule #112
Merged
Update submodule #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 7, 2024 09:28
Updating the submodule to get changes from this specific commit: samvera/hyku@0d1a265 Ref: - #75
There was a flaky spec that ocurred when the CdlsController spec ran. As far as I can tell, it was happening when a CDL factory was being created. I didn't chase this one down too far but the fix was making a watered down SolrDocument instead of creating a CDL and then turning that into a SolrDcoument. This saves a trip to the database and makes the spec a little faster as well.
kirkkwang
force-pushed
the
update-submodule
branch
from
01d8a11 to
3fed8d5
Compare
ShanaLMoore
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
Update submodule
fb2ccd1
Updating the submodule to get changes from this specific commit:
samvera/hyku@0d1a265
Ref:
✅ Fix flaky spec with Advanced Search
3fed8d5
There was a flaky spec that ocurred when the CdlsController spec ran. As
far as I can tell, it was happening when a CDL factory was being
created. I didn't chase this one down too far but the fix was making a
watered down SolrDocument instead of creating a CDL and then turning
that into a SolrDcoument. This saves a trip to the database and makes
the spec a little faster as well.
Expected Behavior Before Changes
A cultural heritage theme homepage crashed when having a date facet that used the blacklight_range_limit gem. In fact the catalog page also had this problem.
Expected Behavior After Changes
No more crashing because of the blacklight_range_limit gem.
Screenshots / Video