Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Search Dropdown Menu Styling #185

Merged
merged 2 commits into from
Jan 15, 2025
Merged

🐛 Search Dropdown Menu Styling #185

merged 2 commits into from
Jan 15, 2025

Conversation

sjproctor
Copy link
Contributor

Story: [i156] Search Dropdown Menu Styling

Ref:

Expected Behavior Before Changes

  • Search form dropdown menus missing styles
  • Dropdown menu opened on the left side of the search bar
  • Dropdown menu lacked margin/padding
  • Dropdown links on some themes had text-decoration:underline while others did not

Expected Behavior After Changes

  • Search form dropdown opens to the right of the screen, just under the All button
  • Dropdown menu has pleasant styling
  • Dropdown menus on all themes match

Screenshots / Video

Default theme - before Screenshot 2025-01-14 at 3 51 06 PM
Default theme - after Screenshot 2025-01-14 at 3 52 28 PM

Notes

This commit:

  • updates dropdown menu styling in the _search_form.html.erb override file to match the structure and style of dropdown menu in Hyrax which fixes reported styling errors
  • updates the submodule that contains similar fixes to the dropdown menu overrides for the Cultural and Institutional Repository themes

This commit:
- updates dropdown menu styling in the `_search_form.html.erb` override
file to match the structure and style of dropdown menu in Hyrax which
fixes reported styling errors
- updates the submodule that contains similar fixes to the dropdown menu
overrides for the Cultural and Institutional Repository themes

Ref:
- #156
Copy link
Contributor

@kirkkwang kirkkwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@sjproctor sjproctor merged commit b3bdd5b into main Jan 15, 2025
6 checks passed
@sjproctor sjproctor deleted the i156-search-dropdown branch January 15, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants