🚧 Knapsack EPIC #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
February 23, 2024 04:33
i2-knapsack-pals is i35-valkyrize-hyku + contributions from the pals knapsacking process
trying to get the app to spin up after knapsacking
ShanaLMoore
commented
Feb 28, 2024
There was a problem hiding this comment.
Contribute back to hyku?
ShanaLMoore
commented
Feb 28, 2024
There was a problem hiding this comment.
contribute back to hyku?
1 task
The structure of the stored collection type gid changed in Hyrax 3.0 A rake task is needed to update the collection_type_gid that is stored on the collection as part of the upgrade from Hyrax 2.x process. This references the logic from the rake task that Hyrax has in versons 3 & 4, and updates it to work within Hyku tenants. The definition of collection_type_gid= changed in Hyrax 5.0. This rake task is known to work for updates to versions prior to Hyrax 5. Functionality for later versions is unknown.
Prior to this commit we were blanket checking CSV recores for the presence of title and resource_type. The problem with this approach was that all models were being checked for these fields while not all models required these fields, such as the Collection and FileSet models. In this commit we leverage the exisiting `Bulkrax::CsvParserDecorator` to check each model's actual required fields according to their respective forms (minus the FileSet which do not have required fields) and add logic to check any custom parser mappings according to the bulkrax initializer and also any numbered fields. The error message was also changed to indicate which model was missing what required field(s). Ref: - notch8/palni-palci#436
This commit makes it so we can use Bulkrax to import locations into the based_near property. It also will work for invalid locations.
This commit will fix a bug where if the csv has a `location` header but no value.
This commit will adjust the Bulkrax csv parser fields to allow spaces in the csv headers. Previously, if you had `rights statement`, this header was not accepted. With this commit it will be.
|
Acknowledging that I've noticed and will look into the recent build issue |
|
I don't understand the failing build's error: 
This branch exists in hyku_knapsack. i can build and bundle successfully, locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
Related
Refs #issuenumber
Expected Behavior Before Changes
Expected Behavior After Changes
Screenshots / Video
Notes