updates from the webstore #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`req.reply()` was not returning an empty response, it was returning the actual response from the server. this led to the "loading" state being present momentarily before the actual response was returned. we are now forcing the loading state to remain, as the mock intends.
made the cypress config file more dynamic. it also will allow us to correctly intercept api calls in our `customApiIntercept` command. update the "featured services list is loading" test check that we in fact have 3 placeholder items, as the description states.
changed up the specs to fit the flow of the home page. also moving two specs from the browse page to the home page since that's where the requests originate from.
untrack file in .gitignore
although we were catching the error in `#fetcher`, we weren't returning it as an error. it was being returned to the caller as the `data` value. this means none of our `isError` checks for GET requests were working properly. with this commit, we're throwing the error so that we are handling it on the view correctly.
we're testing for an invalid access token now. the `customApiIntercept` command is also simplified.
also further simplified the `customApiIntercept` function.
361 fix home specs
362-requests-specs
363 request specs
instead of only displaying text in the notice we converted the text 'please log in' to be a clickable link to log in issue #383 Co-authored-by: Adrian Carranza <[email protected]> Co-authored-by: Jean Aragon <[email protected]>
Co-authored-by: Alisha Evans <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…equest-message 383-update-disabled-request-message
…into webstore-383
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
ref: