Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts Lint step for pipeline #561

Closed
wants to merge 3 commits into from
Closed

Reverts Lint step for pipeline #561

wants to merge 3 commits into from

Conversation

ShanaLMoore
Copy link
Contributor

@ShanaLMoore ShanaLMoore commented Nov 22, 2023

ref slack convo

Lint step fails on a solr error since October.

Since this is low priority it may be worth understanding what changed in v.14 and why they don't work, when we have time.

This solution is more of a hot fix just to get the pipeline passing, to make it more trustworthy again while we develop.

ref:

@ShanaLMoore ShanaLMoore marked this pull request as ready for review November 22, 2023 15:17
@ShanaLMoore ShanaLMoore marked this pull request as draft November 22, 2023 15:18
@ShanaLMoore ShanaLMoore marked this pull request as ready for review November 22, 2023 15:45
@@ -31,7 +31,6 @@ jobs:
workerTarget: hyku-worker
lint:
needs: build
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted this change for now.

@ShanaLMoore ShanaLMoore requested review from aprilrieger and removed request for aprilrieger November 22, 2023 15:57
@ShanaLMoore ShanaLMoore changed the title Fixed pipeline Reverts Lint step for pipeline Nov 22, 2023
@aprilrieger
Copy link
Collaborator

Closing since as I found the issue on sep pr during my investigation. Thank you for all your efforts here Shana and Team V!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants