Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eslint fails production builds #339

Closed
2 tasks
alishaevn opened this issue Dec 15, 2023 · 0 comments · Fixed by #340
Closed
2 tasks

eslint fails production builds #339

alishaevn opened this issue Dec 15, 2023 · 0 comments · Fixed by #340
Assignees
@alishaevn

Comments

@alishaevn
Copy link
Contributor

alishaevn commented Dec 15, 2023 •
edited
Loading

Story

currently, an eslint error will cause the production build of the app to fail. this has caused us to spend extra time, especially recently, troubleshooting what we thought was a larger issue. primarily because, the issue only happens on production builds, not local or preview ones.

Acceptance Criteria

  • eslint doesn't stop the build from succeeding
  • the lint command is run in a separate workflow

Screenshots / Video

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alishaevn alishaevn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

339 eslint production build notch8/webstore
1 participant
@alishaevn