Upstream updates 12-18-2023 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes were recently made to the purchase orders serializer. this commit updates our code so the app continues working with that change. ref: notch8/webstore#337
we still need to check eslint somewhere in this process though. so I'm creating the build-test-lint workflow. ref: https://nextjs.org/docs/pages/api-reference/next-config-js/eslint
this commit change means we no longer get the error: "Detected next.config.js, no exported configuration found. https://nextjs.org/docs/messages/empty-configuration"
ref: https://nextjs.org/docs/app/building-your-application/testing/cypress#continuous-integration-ci ref: https://github.com/vercel/next.js/tree/canary/examples/with-cypress ref: https://github.com/cypress-io/github-action#end-to-end-testing ref: https://docs.cypress.io/guides/continuous-integration/github-actions
the existing line failed with a "Error: Cannot find module '/home/node/app/bash'" error. Locally and in CI/CD. I found a SO post and tried the suggestion, which worked locally. I'm hoping it will work in CI/CD too. ref: https://stackoverflow.com/a/49647309/8079848
trying to get around the error: > Cypress could not verify that this server is running: > http://localhost:3000 > We are verifying this server because it has been configured as your > baseUrl.
…-build 339 eslint production build
…into upstream-updates-12-18-2023
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
merging since this pr aligns with the upstream code, which was already approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
bring in changes from: