Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Toggle block #9

Merged
merged 4 commits into from
Sep 22, 2024
Merged

Added Toggle block #9

merged 4 commits into from
Sep 22, 2024

Conversation

myjeong19
Copy link
Member

Added Notion Toggle Block component

스크린샷 2024-09-21 오후 2 28 32

@Moon-DaeSeung Moon-DaeSeung added the enhancement New feature or request label Sep 21, 2024
@p-iknow
Copy link
Member

p-iknow commented Sep 21, 2024

@myjeong19
Thank you for your contribution. You marked the pull request title with [Draft], but GitHub already supports a draft feature. I recommend using the draft feature instead.

Please refer to the following image.

image

@myjeong19 myjeong19 changed the title [DRAFT] - Added Toggle block Added Toggle block Sep 22, 2024
@myjeong19
Copy link
Member Author

스크린샷 2024-09-22 오후 5 58 09

@myjeong19
Copy link
Member Author

@p-iknow thank you for your feedback 👍 👍

@Moon-DaeSeung
Copy link
Contributor

thank you for your effort!

could you modify this section? (contributing-kr, contributing) now you make this library support toggle type!

image

@myjeong19
Copy link
Member Author

@Moon-DaeSeung yes, I'll try creating a numbered list. thank you for the review.

Copy link
Contributor

@Moon-DaeSeung Moon-DaeSeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants