Fixes for small colour variations in tests #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 21, 2014 16:07
* Most uses of clampTo8Bit actually didn't want 8-bit integers, but just a clamp between 0 and 255. There are now two functions. quantizeAndInverse says in its comments that these integers are needed, so small colour variations in the tests for this cases are expected * The outputBuffer for quantizeAndInverse was changed back to Int32 to allow greater precision in the calculations
|
This is work in progress, I would better wait and not merge right now |
added 2 commits
March 25, 2014 17:06
…ut after quantisation and inversion. This will make getData() a bit more expensive when done repeatedly for different sizes, but I would guess this is not a common usecase anyway. Benchmarking on big images shows that this is 20% faster.
…ata now and only indirectly blocks
|
More performance improvements: This will make getData() a bit more expensive when done repeatedly for different Benchmarking on big images shows that this is 20% faster. |
…s for every component
yurydelendik
pushed a commit
to yurydelendik/pdf.js
that referenced
this pull request
Mar 26, 2014
yurydelendik
added a commit
that referenced
this pull request
Mar 26, 2014
Fixes for small colour variations in tests
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
between 0 and 255. There are now two functions. quantizeAndInverse says in its
comments that these integers are needed, so small colour variations in the
tests for this cases are expected
greater precision in the calculations