Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add number to Candidates [subgraph] #809

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

pedropregueiro
Copy link
Contributor

This PR adds a number field to the ProposalCandidate graph entity.

The idea behind this change is that the current candidate ID - proposer-slug - generates really big URLs that make it a bit hard to share candidate links around or even quickly open one the same way you do with props (https:..noun-client/proposal/X)

Here are a couple of candidate URLs as we have them today:

With a number index, these would become:

This can later be improved directly in the smart contract, but a subgraph fix will go a long way today.

@solimander solimander merged commit 0568af8 into nounsDAO:master Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants