Skip to content

Commit

Permalink
fix(actions): Remove unused environment input
Browse files Browse the repository at this point in the history
The environment-specific SLACK_WEBHOOK_URL secret has been replaced with a repo-specific secret.
  • Loading branch information
SokratisVidros committed May 9, 2024
1 parent 5aacf34 commit 5649c60
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 21 deletions.
5 changes: 0 additions & 5 deletions .github/workflows/reusable-api-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,6 @@ on:
description: 'job name [options: novu/api-ee, novu/api]'
required: true
type: string
environment:
required: false
default: 'Development'
type: string

# A workflow run is made up of one or more jobs that can run sequentially or in parallel
jobs:
Expand All @@ -51,7 +47,6 @@ jobs:
if: ${{ (contains(inputs.job-name, '-ee') && inputs.test-e2e-ee-affected) || (!contains(inputs.job-name, '-ee') && inputs.test-e2e-affected) }}
runs-on: ubuntu-latest
timeout-minutes: 80
environment: ${{ inputs.environment }}
permissions:
contents: read
packages: write
Expand Down
11 changes: 0 additions & 11 deletions .github/workflows/reusable-web-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,21 +11,13 @@ on:
required: false
default: true
type: boolean
environment:
required: false
default: 'Development'
type: string
workflow_call:
inputs:
ee:
description: 'use the ee version of worker'
required: false
default: false
type: boolean
environment:
required: false
default: 'Development'
type: string

# A workflow run is made up of one or more jobs that can run sequentially or in parallel
jobs:
Expand All @@ -47,7 +39,6 @@ jobs:
# The type of runner that the job will run on
runs-on: ubuntu-latest
timeout-minutes: 80
environment: ${{ inputs.environment }}

permissions:
contents: read
Expand Down Expand Up @@ -170,7 +161,6 @@ jobs:
# Merge reports after playwright-tests, even if some shards have failed
if: ${{ !cancelled() }}
needs: [e2e_web]
environment: ${{ inputs.environment }}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -203,7 +193,6 @@ jobs:
# The type of runner that the job will run on
runs-on: ubuntu-latest
timeout-minutes: 80
environment: ${{ inputs.environment }}

# Steps represent a sequence of tasks that will be executed as part of the job
steps:
Expand Down
5 changes: 0 additions & 5 deletions .github/workflows/reusable-widget-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,6 @@ on:
required: false
default: false
type: boolean
environment:
required: false
default: 'Development'
type: string

# A workflow run is made up of one or more jobs that can run sequentially or in parallel
jobs:
Expand All @@ -22,7 +18,6 @@ jobs:
# The type of runner that the job will run on
runs-on: ubuntu-latest
timeout-minutes: 80
environment: ${{ inputs.environment }}
permissions:
contents: read
packages: write
Expand Down

0 comments on commit 5649c60

Please sign in to comment.