[NV-3037] Fixed closing off the wrong socket in useUnreadCount.ts

[Khongchai]

What change does this PR introduce?

This fixes an issue where the useUnreadCount hook closes the wrong websocket channel.

Why was this change needed?

#4582

Other information (Screenshots)

[djabarovgeorge]

Hey @Khongchai,
Awesome work discovering the issue, could you update the refetch key issue that you located as well here?

[p-fernandez]

I think in line 78 we would need to update to:

enabled: isSessionInitialized && fetchingStrategy.fetchUnreadCount

[Khongchai]

Ok I'll add this

[Khongchai]

@p-fernandez I've updated the condition. But I needed to add a couple of things more because the fetchingStrategy interface was missing the fetchUnreadCount key.

For the default value, I set it to true so that existing code won't break (it was using unseen's default and it was true)

[Khongchai]

Hey @Khongchai, Awesome work discovering the issue, could you update the refetch key issue that you located as well here?

Hi, sorry for my late reply.

The refetch key issue, as I have mentioned in this issue. I'm not quite sure if this really is a problem. I thought it was at first, but after having looked into it further, it was just making sure the unseen value is updated.

I haven't checked Novu's code on this part, but should unseen be updated if unread is updated? I thought there was a bug, but after reading this comment, I'm not so sure

For example, if something is marked as read should they also be marked automatically as seen? If so, the code is already working as intended (maybe some Novu backend logic to update all read fields as seen).

If my understanding is incorrect and the refetch function was really not working as intended in some way, please let me know.

[p-fernandez]

🌟