-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(js): js sdk preferences #5701
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
348b4fd
feat(js): the base js sdk package scaffolding
LetItRock 9a85fb5
feat(js): improve the package json exports and tsup config
LetItRock a2627c6
feat(js): lazy session initialization and interface fixes
LetItRock c753c57
feat(js): renamed the *.spec.ts to *.test.ts
LetItRock 438661f
feat(js): js sdk feeds module
LetItRock dc66186
chore(js): spell check fix
LetItRock d035e6f
feat(js): the base js sdk package scaffolding
LetItRock 9d75acc
feat(js): set the dist file size limits and run the check after the b…
LetItRock b19f98f
feat(js): lazy session initialization and interface fixes
LetItRock cc21e68
feat(js): renamed the *.spec.ts to *.test.ts
LetItRock bd17c58
feat(js): js sdk feeds module
LetItRock a22b888
feat(js): js sdk preferences
LetItRock 68987c2
chore(js): simplified the notification and preference classes
LetItRock 8c6464a
feat(js): temporarily increased bundle size limits
LetItRock File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
import { ApiService } from '@novu/client'; | ||
|
||
import type { NovuEventEmitter } from '../event-emitter'; | ||
import type { TODO } from '../types'; | ||
import { PreferenceLevel } from '../types'; | ||
import { Preference } from './preference'; | ||
import type { UpdatePreferencesArgs } from './types'; | ||
|
||
export const mapPreference = (apiPreference: { | ||
template?: TODO; | ||
preference: { | ||
enabled: boolean; | ||
channels: { | ||
email?: boolean; | ||
sms?: boolean; | ||
in_app?: boolean; | ||
chat?: boolean; | ||
push?: boolean; | ||
}; | ||
}; | ||
}): Preference => { | ||
const { template: workflow, preference } = apiPreference; | ||
const hasWorkflow = workflow !== undefined; | ||
const level = hasWorkflow ? PreferenceLevel.TEMPLATE : PreferenceLevel.GLOBAL; | ||
|
||
return new Preference({ | ||
level, | ||
enabled: preference.enabled, | ||
channels: preference.channels, | ||
workflow: hasWorkflow | ||
? { | ||
id: workflow?._id, | ||
name: workflow?.name, | ||
critical: workflow?.critical, | ||
identifier: workflow?.identifier, | ||
data: workflow?.data, | ||
} | ||
: undefined, | ||
}); | ||
}; | ||
|
||
export const updatePreference = async ({ | ||
emitter, | ||
apiService, | ||
args, | ||
}: { | ||
emitter: NovuEventEmitter; | ||
apiService: ApiService; | ||
args: UpdatePreferencesArgs; | ||
}): Promise<Preference> => { | ||
const { workflowId, enabled, channel } = args; | ||
try { | ||
emitter.emit('preferences.update.pending', { args }); | ||
|
||
let response; | ||
if (workflowId) { | ||
response = await apiService.updateSubscriberPreference(workflowId, channel, enabled); | ||
} else { | ||
response = await apiService.updateSubscriberGlobalPreference([{ channelType: channel, enabled }]); | ||
} | ||
LetItRock marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
const preference = new Preference(mapPreference(response)); | ||
emitter.emit('preferences.update.success', { args, result: preference }); | ||
|
||
return preference; | ||
} catch (error) { | ||
emitter.emit('preferences.update.error', { args, error }); | ||
throw error; | ||
} | ||
}; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We provide newer APIs but it wasn't exposed with this ApiService class.