fix(api): make zod optional #7056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SokratisVidros
approved these changes
Nov 18, 2024
rifont
reviewed
Nov 18, 2024
| @@ -61,26 +61,26 @@ const InAppRenderOutputSchema = z.object({ | |||
| avatar: z.string().optional(), | |||
| primaryAction: z | |||
| .object({ | |||
| label: z.string(), | |||
| label: z.string().optional(), | |||
There was a problem hiding this comment.
I don't think this is the right approach, it's invalid to have a primary action without a label, etc. The correct fix IMO is to not send an empty object for primaryAction when the primary action isn't needed.
There was a problem hiding this comment.
Are you talking about not sending an empty object from the FE to the API or preprocess the control values here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
zod is failing preview calls
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer